Bug 407698

Summary:	Cannot deactivate samba shares on neon dev unstable
Product:	[Frameworks and Libraries] kdenetwork-filesharing	Reporter:	Patrick Silva <bugseforuns>
Component:	general	Assignee:	Unassigned bugs mailing-list <unassigned-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://commits.kde.org/kdenetwork-filesharing/27ebbf47a81608fea27512fc08be8676411e71a8	Version Fixed In:
Sentry Crash Report:

Description Patrick Silva 2019-05-18 18:37:11 UTC

SUMMARY
maybe a regression related to the fix for bug 407500.

STEPS TO REPRODUCE
1. open Dolphin
2. open the properties window of any shared folder
3. click "Share" tab
4. uncheck "Share this folder..."

OBSERVED RESULT
you can not apply the change because "Ok" button is greyed out.

EXPECTED RESULT
"OK" button is clickable

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.16.80
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.0


ADDITIONAL INFORMATION
I can' reproduce with kdenetwork-filesharing 19.04.1 on Arch Linux.

Comment 1 Nate Graham 2019-05-21 20:46:11 UTC

Oh goodness.

Comment 2 Nate Graham 2019-05-21 20:56:31 UTC

Git commit 27ebbf47a81608fea27512fc08be8676411e71a8 by Nate Graham.
Committed on 21/05/2019 at 20:49.
Pushed by ngraham into branch 'Applications/19.04'.

Don't ever disable the OK button when the user is trying to remove a share

M  +5    -0    samba/filepropertiesplugin/sambausershareplugin.cpp

https://commits.kde.org/kdenetwork-filesharing/27ebbf47a81608fea27512fc08be8676411e71a8

Comment 3 Nate Graham 2019-05-21 20:57:20 UTC

Thanks very much for noticing this quickly. Keep 'em coming! I'm going to be working on this code more.