Summary: | Delete applet config window and move its two options into the KCM | ||
---|---|---|---|
Product: | [Plasma] plasma-nm | Reporter: | Kishore Gopalakrishnan <kishore96> |
Component: | applet | Assignee: | Jan Grulich <jgrulich> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, lukas, nate |
Priority: | NOR | Keywords: | usability |
Version: | 5.15.5 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-nm/7601936e36429357b89b779b939fa231737fa3a5 | Version Fixed In: | 5.18.0 |
Description
Kishore Gopalakrishnan
2019-05-15 14:57:39 UTC
IMO the real solution here is to remove the configuration window and move its two options into the KCM. This is what we did for the Notifications applet recently. I confirm that the wording of the 2 options is not helpful, is has very little explanatory value. *** Bug 412068 has been marked as a duplicate of this bug. *** Apologies for the dupe - thanks for marking it, Nate. Glad to see this is already being tracked No worries! Git commit 7601936e36429357b89b779b939fa231737fa3a5 by Jan Grulich. Committed on 18/12/2019 at 13:48. Pushed by grulich into branch 'master'. Move applet configuration to KCM Summary: It doesn't make sense to have additional applet configuration, especially when the configuration is not related only to the applet. Reviewers: ngraham, #plasma Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D26041 D +0 -33 applet/contents/config/config.qml D +0 -19 applet/contents/config/main.xml D +0 -52 applet/contents/ui/configGeneral.qml M +2 -8 applet/contents/ui/main.qml M +2 -1 kcm/CMakeLists.txt R +0 -0 kcm/qml/AddConnectionDialog.qml [from: kcm/qml/Dialog.qml - 100% similarity] A +109 -0 kcm/qml/ConfigurationDialog.qml [License: LGPL] M +40 -15 kcm/qml/main.qml https://commits.kde.org/plasma-nm/7601936e36429357b89b779b939fa231737fa3a5 |