Summary: | help buttons broken; depend on khelpcenter | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Harald Sitter <sitter> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, contact, jr |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/systemsettings/0be65944f311145246e5c0cc2d5326d77dc4abdb | Version Fixed In: | 5.18.1 |
Description
Harald Sitter
2019-03-19 14:26:43 UTC
*** Bug 400602 has been marked as a duplicate of this bug. *** *** Bug 380081 has been marked as a duplicate of this bug. *** Git commit 0be65944f311145246e5c0cc2d5326d77dc4abdb by Ahmad Samir. Committed on 27/02/2020 at 15:47. Pushed by ahmadsamir into branch 'master'. If KHelpCenter isn't available fallback to opening doc at docs.kde.org Summary: UrlHandler from KGUIAddons sets a handler for help:/ urls, which opens khelpcenter if it's available or falls back to opening the relevant page at docs.kde.org. Explicitly add KGuiAddons to find_package() and target_link_libraries(). Depends on D27615 FIXED-IN: 5.18.1 Test Plan: - make sure khelpcenter is not installed and open systemsettings - navigate to any module (one that has Help visible, e.g. Fonts), "Help" button is disabled - install khelpcenter and restart systemsettings, the "Help" button should be enabled Reviewers: #plasma, apol Reviewed By: apol Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27518 M +1 -0 CMakeLists.txt M +1 -0 app/CMakeLists.txt M +5 -2 core/ModuleView.cpp https://commits.kde.org/systemsettings/0be65944f311145246e5c0cc2d5326d77dc4abdb *** Bug 405646 has been marked as a duplicate of this bug. *** |