Bug 405646 - help buttons broken; depend on khelpcenter
Summary: help buttons broken; depend on khelpcenter
Status: RESOLVED DUPLICATE of bug 405647
Alias: None
Product: kinfocenter
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Hubner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-19 14:25 UTC by Harald Sitter
Modified: 2020-04-07 10:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2019-03-19 14:25:27 UTC
In 2016 we moved khelpcenter from plasma to applications with the expectation that we'll simply let help requests fall back to the docs.kde.org website when khelpcenter is not installed (which ought to be the default expectation I guess since the unreliable state of khelpcenter is why it was dropped from plasma to begin with).

KInfocenter modules help however still 100% depends on khelpcenter

void KInfoCenter::helpClickedSlot()
{
    // Nicked from Ben, could not use KToolInvocation due to docpath.
    QString docPath = m_contain->helpPath();

    QUrl url(QStringLiteral("help:/") + docPath );
    QProcess::startDetached(QStringLiteral("khelpcenter"), QStringList() << url.url());
}
Comment 1 Luigi Toscano 2019-03-19 14:37:32 UTC
> (which ought to be the default expectation I guess since the unreliable state of khelpcenter is why it was dropped from plasma to begin with).

It was more about "we don't need offline documentation", if I rememeber correctly. Anyway, the fix for kinfocenter should be easy enough.
Comment 2 Harald Sitter 2020-04-07 10:53:54 UTC
master's KIC shell has been merged into systemsettings' so the code is now shared

*** This bug has been marked as a duplicate of bug 405647 ***