Bug 397768

Summary:	"Trim" menu items need appropriate icons
Product:	[Applications] okular	Reporter:	Clinton <clintonthegeek>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	nate
Priority:	NOR
Version First Reported In:	1.5.0
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	https://commits.kde.org/okular/259961f6d18fde46d0faf57b18a482324e888a24	Version Fixed/Implemented In:	19.04.0
Sentry Crash Report:
Bug Depends on:	401489
Bug Blocks:

Description Clinton 2018-08-23 03:11:54 UTC

Using Okular as my primary ebook reader, I am constantly applying the "Trim to margins" feature to decrease useless whitespace.

I suggest assigning the very intuitive "ratiocrop" (or "transform-crop") icon as default to this entry when made a toolbar button.

Comment 1 Nate Graham 2018-08-31 23:17:38 UTC

Submitted a patch for this: https://phabricator.kde.org/D15193

Comment 2 Nate Graham 2018-11-27 23:07:31 UTC

After review, it became clear that we need new icons before we can do this. See Bug 401489.

Comment 3 Nate Graham 2019-01-26 20:57:37 UTC

Git commit 259961f6d18fde46d0faf57b18a482324e888a24 by Nate Graham.
Committed on 26/01/2019 at 20:57.
Pushed by ngraham into branch 'master'.

Add icons for the Trim Margins tools

Summary:
New icons were added in D18552.
FIXED-IN: 19.04.0

Test Plan: {F6569231, size=full}

Reviewers: #okular, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, trickyricky26, aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D15193

M  +2    -2    ui/pageview.cpp

https://commits.kde.org/okular/259961f6d18fde46d0faf57b18a482324e888a24