Bug 396725

Summary: Configure desktop effects dialog:reading the effect names is impossible with fractional scaling
Product: [Applications] systemsettings Reporter: Matthias Fabinski <matthias.fab>
Component: generalAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, kde, nate, patrick.deubel, pawelcislo
Priority: NOR    
Version: 5.13.3   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
URL: https://bugreports.qt.io/browse/QTBUG-70481
See Also: https://bugs.kde.org/show_bug.cgi?id=402701
Latest Commit: Version Fixed In: 5.15.0
Sentry Crash Report:
Attachments: Shows the desktop effects dialog with the bug

Description Matthias Fabinski 2018-07-21 12:38:43 UTC
Created attachment 114047 [details]
Shows the desktop effects dialog with the bug

Application systemsettings
Version 5.13.3
Linux (x86_64) release 4.17.8-1-ARCH

When opening the Desktop Effects Dialog in System Settings the text cannot be read. I attach a screenshot of the dialog. 

I think the issue results from my scaling settings (upgraded to 4k monitor) which I set to scalingfactor 1.2 with the default Displays System Settings dialog. Furthermore i set the Fonts with "Force Fonts DPI" to 115. 

Changing the window size of the dialog does not change the outcome, the problem persists. It happens with Treeview, Icon View and Sidebar View.

Other dialogs in the systemsettings work without a problem.

Kind regards,
Matthias Fabinski
Comment 1 Matthias Fabinski 2018-07-22 18:23:20 UTC
small update: I tested with different scaling factors and found out, that with 1.0, 2.0 and 3.0 the dialog works properly. 

The following scaling factors where tested and had similar graphical glitches: 1.2, 1.5, 2.5. 

The fontsetting has no impact on this, so it can be ignored in further work on this bug.

Can someone point me to the sourcecode (repository) of the Desktop Effects Dialog, as i was not able to find it. Information about where to find documentation about the settingsapplication would be appreciated too.

Kind regards,
Matthias Fabinski
Comment 2 David Edmundson 2018-07-22 22:00:59 UTC
kcmkwin/kwincompositing
Comment 3 Christoph Feck 2018-07-22 23:55:00 UTC
kwin repo at https://cgit.kde.org/kwin.git/

> Information about where to find documentation about the settingsapplication would be appreciated too.

https://docs.kde.org/index.php?language=en&package=kde-workspace
Comment 4 Patrick Silva 2018-07-25 22:48:16 UTC
*** Bug 395566 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2019-01-02 19:45:32 UTC
Patch to fix this: https://phabricator.kde.org/D17928
Comment 6 Nate Graham 2019-01-06 06:32:46 UTC
*** Bug 386216 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2019-01-06 23:09:13 UTC
Git commit d28827626931ed9f8fbfd618bbdcdf3fdce6a5e6 by Nate Graham.
Committed on 06/01/2019 at 23:09.
Pushed by ngraham into branch 'master'.

[kcmkwin/compositing] Port Effects KCM to QQC2

Summary:
This patch ports the Effects KCM to QQC2, which yields the following benefits:
1. General performance enhancements of only using QQC2 rather than a mix of 1 and 2
2. Some code simplification is possible
3. Improves the appearance of the checkable menu items in the dropdown menu, fixing https://bugs.kde.org/show_bug.cgi?id=402701
4. Improves the appearance when using a fractional scale factor, fixing https://bugs.kde.org/show_bug.cgi?id=396725
5. Fixes the incorrect size when opened from `kcmshell5`

Along the way, two visual changes are introduced as a by-product of porting:
1. The scrollbar is inline, so it overlaps some of the buttons in the content. This is somewhat undesirable, but adopting a Kirigami scrollview would fix this.
2. The button that displays a dropdown menu no longer has a downward-pointing arrow to indicate as such. This is not my preference, but there's a benefit to being consistent, and eventually we could can change this in one place to impeove the appearance of buttons that display dropdown menus everywhere in one fell swoop.
Related: bug 402701, bug 396076
FIXED-IN: 5.15.0

Test Plan:
All functionality still works

In System Settings, showing improved checkable menu item appearance:
{F6523385}

In `kcmshell` at 1x scale:
{F6523386}

In `kcmshell` at 1.5x scale:
{F6523387}

Reviewers: #kwin, #plasma, davidedmundson

Reviewed By: #kwin, #plasma, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D17928

M  +60   -63   kcmkwin/kwincompositing/qml/EffectView.qml

https://commits.kde.org/kwin/d28827626931ed9f8fbfd618bbdcdf3fdce6a5e6