Bug 386216 - Desktop Behavior/Desktop Effects KCM: use of QtQuickControls1 and/or PlasmaComponents labels causes blurry pixellated text with non-integer scale factors
Summary: Desktop Behavior/Desktop Effects KCM: use of QtQuickControls1 and/or PlasmaCo...
Status: RESOLVED DUPLICATE of bug 396725
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.11.2
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-26 17:04 UTC by Pawel
Modified: 2019-01-06 06:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fonts in Desktop effects (202.16 KB, image/png)
2017-10-26 17:04 UTC, Pawel
Details
badly scaled fonts in settings>desktop effects and menu (224.80 KB, image/png)
2017-10-29 16:24 UTC, Pawel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel 2017-10-26 17:04:13 UTC
Created attachment 108574 [details]
Fonts in Desktop effects

After I've scaled my display at 1.2x, fonts look really bad on some pages in the Settings (see attachment).
Comment 1 Nate Graham 2017-10-26 17:18:27 UTC
Can you upgrade to 5.11.x and see if the fonts on System Settings' new Sidebar also look pixellated? If so, this is https://bugs.kde.org/show_bug.cgi?id=385547
Comment 2 Pawel 2017-10-26 18:48:15 UTC
(In reply to Nate Graham from comment #1)
> Can you upgrade to 5.11.x and see if the fonts on System Settings' new
> Sidebar also look pixellated? If so, this is
> https://bugs.kde.org/show_bug.cgi?id=385547

I don't really know how to do that. I guess I'll just wait.
Comment 3 Pawel 2017-10-29 15:00:21 UTC
(In reply to Nate Graham from comment #1)
> Can you upgrade to 5.11.x and see if the fonts on System Settings' new
> Sidebar also look pixellated? If so, this is
> https://bugs.kde.org/show_bug.cgi?id=385547

Just upgraded to 5.11.2. The sidebar seems OK, but the fonts in the little menu on the left of the search box seem a bit pixellated.
Comment 4 Nate Graham 2017-10-29 16:11:10 UTC
Can you attach another screenshot, and mark the old one as obsolete?
Comment 5 Pawel 2017-10-29 16:24:43 UTC
Created attachment 108631 [details]
badly scaled fonts in settings>desktop effects and menu
Comment 6 Nate Graham 2017-10-29 16:26:47 UTC
Thanks. Pretty sure this is the same underlying issue as Bug 385547.

*** This bug has been marked as a duplicate of bug 385547 ***
Comment 7 Nate Graham 2018-03-16 22:27:16 UTC
Git commit a21bc11fe11651f6d211489ebfc8435cef877194 by Nathaniel Graham.
Committed on 16/03/2018 at 22:26.
Pushed by ngraham into branch 'master'.

Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

Summary:
When `PLASMA_USE_QT_SCALING=1` is set, Plasma uses native Qt scaling. This works fine for integer scale factors, and fixes a lot of bugs (see [[https://bugs.kde.org/show_bug.cgi?id=356446|Bug 356446]]) but it introduces a new one: with non-integer scale factors, text becomes blurry and pixellated because of a bug in `Text.NativeRendering`: https://bugreports.qt.io/browse/QTBUG-67007

QQC2-desktop-style forces the use of `Text.QtRendering` rendering for non-integer scale factors, successfully working around the problem. But PlasmaComponents QML objects don't implement the same workaround, so we see the issue in Plasma. This patch fixes that, and gets us one step closer to being able to use Qt scaling in Plasmashell.

There is no effect when `PLASMA_USE_QT_SCALING=1` is not being used.

FIXED-IN 5.13
Related: bug 391691, bug 384031, bug 391695, bug 391694, bug 385547, bug 391692, bug 356446

Test Plan:
Before: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks awful:
{F5749797}

After: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks amazing!
{F5749798}

Note that we still get sub-pixel anti-aliasing and good kerning. There appear to be no layout regressions.

Without both `PLASMA_USE_QT_SCALING=1` and a non-integer scale factor set, there is no visual change compared to the status quo.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, broulik, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D11244

M  +4    -2    examples/applets/testtheme/contents/ui/FontGizmo.qml
M  +5    -1    src/declarativeimports/plasmacomponents/qml/Label.qml
M  +5    -1    src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
M  +4    -0    src/declarativeimports/plasmacomponents3/ComboBox.qml
M  +5    -1    src/declarativeimports/plasmacomponents3/Label.qml
M  +5    -1    src/declarativeimports/plasmacomponents3/TextArea.qml
M  +5    -1    src/declarativeimports/plasmacomponents3/TextField.qml
M  +5    -0    src/declarativeimports/plasmastyle/ComboBoxStyle.qml
M  +4    -1    src/declarativeimports/plasmastyle/SpinBoxStyle.qml
M  +4    -1    src/declarativeimports/plasmastyle/TextAreaStyle.qml
M  +4    -1    src/declarativeimports/plasmastyle/TextFieldStyle.qml

https://commits.kde.org/plasma-framework/a21bc11fe11651f6d211489ebfc8435cef877194
Comment 8 Nate Graham 2019-01-06 06:32:46 UTC
Remaining issues will be tracked at 396725.

*** This bug has been marked as a duplicate of bug 396725 ***