Bug 396076 - Desktop effects KCM - Window Size too small when opened from kcmshell5
Summary: Desktop effects KCM - Window Size too small when opened from kcmshell5
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.13.90
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-02 07:51 UTC by Murat Çileli
Modified: 2019-01-06 23:09 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.0
Sentry Crash Report:


Attachments
Network Manager (67.11 KB, image/png)
2018-07-02 07:51 UTC, Murat Çileli
Details
Desktop Effects (59.85 KB, image/png)
2018-07-02 07:54 UTC, Murat Çileli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Murat Çileli 2018-07-02 07:51:53 UTC
Created attachment 113699 [details]
Network Manager

Sorry if not KWin related. Some windows has wrong size and always start with same wrong size. Example 1: Network Manager Applet -> Configure Network Connections - Example 2: Run Desktop Effects from KRunner. Screenshot attached.
Comment 1 Murat Çileli 2018-07-02 07:54:47 UTC
Created attachment 113700 [details]
Desktop Effects
Comment 2 Christoph Feck 2018-07-02 13:55:23 UTC
The default size hint for scroll areas is too small. The recently added scroll area should inherit the size hint from its contents.
Comment 3 Nate Graham 2018-08-05 13:44:25 UTC
Christoph, if you have some idea of what's wrong here, any chance you could submit a patch? The parent issue is really racking up duplicates.

*** This bug has been marked as a duplicate of bug 389585 ***
Comment 4 Christoph Feck 2018-08-05 14:00:12 UTC
See my comment at bug 394747.
Comment 5 Patrick Silva 2018-09-18 12:06:40 UTC
Problem persists with desktop effects kcm.
Not a duplicate of bug 389585, a different fix is required here.
Comment 6 Nate Graham 2018-09-18 14:10:34 UTC
Per investigation in Bug 396076, this is caused by the UI not providing a proper sizeHint.
Comment 7 Nate Graham 2019-01-06 23:09:13 UTC
Git commit d28827626931ed9f8fbfd618bbdcdf3fdce6a5e6 by Nate Graham.
Committed on 06/01/2019 at 23:09.
Pushed by ngraham into branch 'master'.

[kcmkwin/compositing] Port Effects KCM to QQC2

Summary:
This patch ports the Effects KCM to QQC2, which yields the following benefits:
1. General performance enhancements of only using QQC2 rather than a mix of 1 and 2
2. Some code simplification is possible
3. Improves the appearance of the checkable menu items in the dropdown menu, fixing https://bugs.kde.org/show_bug.cgi?id=402701
4. Improves the appearance when using a fractional scale factor, fixing https://bugs.kde.org/show_bug.cgi?id=396725
5. Fixes the incorrect size when opened from `kcmshell5`

Along the way, two visual changes are introduced as a by-product of porting:
1. The scrollbar is inline, so it overlaps some of the buttons in the content. This is somewhat undesirable, but adopting a Kirigami scrollview would fix this.
2. The button that displays a dropdown menu no longer has a downward-pointing arrow to indicate as such. This is not my preference, but there's a benefit to being consistent, and eventually we could can change this in one place to impeove the appearance of buttons that display dropdown menus everywhere in one fell swoop.
Related: bug 396725, bug 402701
FIXED-IN: 5.15.0

Test Plan:
All functionality still works

In System Settings, showing improved checkable menu item appearance:
{F6523385}

In `kcmshell` at 1x scale:
{F6523386}

In `kcmshell` at 1.5x scale:
{F6523387}

Reviewers: #kwin, #plasma, davidedmundson

Reviewed By: #kwin, #plasma, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D17928

M  +60   -63   kcmkwin/kwincompositing/qml/EffectView.qml

https://commits.kde.org/kwin/d28827626931ed9f8fbfd618bbdcdf3fdce6a5e6