Bug 395469

Summary: crashes with color sliders with HSI, HSY'...
Product: [Applications] krita Reporter: remi <remifontan>
Component: Color SelectorsAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 4.0.4   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: https://commits.kde.org/krita/8b366fe6834cf26388266142eeb96a95dd58e72a Version Fixed In:
Sentry Crash Report:
Attachments: lldb backtrace

Description remi 2018-06-16 01:02:06 UTC 
when playing with color sliders with multiple color model at the same time, I quickly get crash.

steps to reproduce the crash:
1. open Krita
2. create new document:
my document was open in RGA/Alpha. 32bitsfloat/channel, profile "sRGB-elle-V2-g10.icc (default)".
3. in "Advanced color Selector" click on the setting icon and in Docker:"Color sliders" add "HSV", "HSI" and "HSY'" all sliders, then validate settings
4. play with color sliders in the "Color Sliders" docker.

in following reported crash I had HSV, HSI and HSY' at the same time, and was playing with each sliders to understand their how they are related. Krita would crash quickly (less than 5 min).


attached is a backtrace of the crash I got when launching krita as follow:

lldb /Applications/Krita.app/Contents/MacOS/krita 

my os: OSX 10.11.6
MacBook Pro (15-inch, Mid 2009)
2.66 GHz Intel Core 2 Duo
8 GB 1067 MHz DDR3
NVIDIA GeForce 9600M GT 256 MB
Comment 1 remi 2018-06-16 01:03:48 UTC 
Created attachment 113364 [details]
lldb backtrace
Comment 2 Halla Rempt 2018-06-16 08:20:53 UTC 
Git commit dd434d69ce24cc644322394f4f6184e9600508d5 by Boudewijn Rempt.
Committed on 16/06/2018 at 08:20.
Pushed by rempt into branch 'master'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 352940, bug 385405, bug 379691

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/dd434d69ce24cc644322394f4f6184e9600508d5
Comment 3 Halla Rempt 2018-06-16 08:22:24 UTC 
Git commit e3301f9727c4be2ba9a58172dc53c80d57471b14 by Boudewijn Rempt.
Committed on 16/06/2018 at 08:22.
Pushed by rempt into branch 'krita/4.1'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 352940, bug 385405, bug 379691
(cherry picked from commit 2553aa1e50640a6f757c458b560e2bbb7ca0f239)

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/e3301f9727c4be2ba9a58172dc53c80d57471b14
Comment 4 Andrey 2018-06-26 15:13:34 UTC 
Git commit 8b366fe6834cf26388266142eeb96a95dd58e72a by Andrey Kamakin, on behalf of Boudewijn Rempt.
Committed on 26/06/2018 at 14:18.
Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 352940, bug 385405, bug 379691

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/8b366fe6834cf26388266142eeb96a95dd58e72a