Summary: | Skins can't be installed from KNS | ||
---|---|---|---|
Product: | [Applications] yakuake | Reporter: | Lionel Chauvin <megabigbug> |
Component: | general | Assignee: | Eike Hein <hein> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | abbreviatedman, bugseforuns, l3d84ss, nate, neousr, spaceboyross, tdhj744ra03u, zrenfire |
Priority: | NOR | ||
Version: | Git (Frameworks 5) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/yakuake/d9537fcba90ba912c8ea50c4733d6189cdb15b01 | Version Fixed In: | |
Attachments: |
patch
attachment-5878-0.html |
Description
Lionel Chauvin
2018-06-03 22:13:47 UTC
Hi, Ein Kein Can I add you as a reviewer on https://phabricator.kde.org/D13335 ? Hi, Eike Hein Can I add you as a reviewer on https://phabricator.kde.org/D13335 ? Just wanted to confirm the bug, have to install skins manually. *** Bug 399887 has been marked as a duplicate of this bug. *** Can confirm this on Plasma 5.14.5 some time ago i circumvented this by manually installing a skin. *** This bug has been marked as a duplicate of bug 390155 *** How does one manually install a yakuake skin? Created attachment 118570 [details] attachment-5878-0.html Download skin and extract it to ~/.local/share/yakuake/kns_skins/ вт, 5 мар. 2019 г., 6:21 Colin Jaffe <bugzilla_noreply@kde.org>: > https://bugs.kde.org/show_bug.cgi?id=395012 > > Colin Jaffe <abbreviatedman@posteo.net> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |abbreviatedman@posteo.net > > --- Comment #7 from Colin Jaffe <abbreviatedman@posteo.net> --- > How does one manually install a yakuake skin? > > -- > You are receiving this mail because: > You are on the CC list for the bug. Git commit d9537fcba90ba912c8ea50c4733d6189cdb15b01 by Eike Hein, on behalf of Lionel Chauvin. Committed on 10/03/2019 at 07:30. Pushed by hein into branch 'master'. Fix Skin validation when installed from KNS Summary: When a Skin is downloaded from KNS, Yakuake fails to validate the presence of title.skin and tabs.skin files. The skin is then uninstalled even if these files exist. This is due to this optimization of KNS: https://phabricator.kde.org/D6104 Files are not listed anymore by entry.installedFiles(). They are replaced by paths that end with /* In order to fix this bug I changed the validateSkin method so that it checks the presence of files in the filesystem instead of in a list of entries returned by KNS. Test Plan: Download a Skin from KNS: It should not complain about missing files. Install a correct skin from local: it should not complain about missing files; Install a wrong skin from local: it should complain about missing files; Install a correct skin already installed from local: it should ask for overwrite existing skin. Reviewers: hein, apol, #yakuake Reviewed By: hein Subscribers: Zren, hein, apol, chauvin Tags: #yakuake Differential Revision: https://phabricator.kde.org/D13335 M +45 -59 app/config/appearancesettings.cpp M +4 -3 app/config/appearancesettings.h https://commits.kde.org/yakuake/d9537fcba90ba912c8ea50c4733d6189cdb15b01 *** Bug 390155 has been marked as a duplicate of this bug. *** Yakuake is not part of KDE Applications, but released separately. |