| Summary: | New Libinput mouse KCM removed single-click/double-click setting | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Nate Graham <nate> |
| Component: | kcm_mouse | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugseforuns, furkantokac34, subdiff, unassigned-bugs |
| Priority: | VHI | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/d3ef895516fed319956e4ba843206dd118b998f5 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-04-26 16:08:25 UTC
It makes more sense to put it in: "Desktop Behavior -> Workspace" My long term goal is to gather there other general config options too, for example animation speed from the Compositor KCM. Sounds good to me, but FWIW I proposed that in Bug 377310 a year ago, and you shot it down! :P Maybe we should rename that KCM to be "General", then. Not sure why I said this back then. Probably because the plan was to get rid of this KCM with the only two checkboxes. But I now think it's better to keep it and make it more relevant by moving settings from other KCMs to this one (as for example animation speed from compositor KCM). I made the investigation and working on it. Plan 1- Porting "Dekstop Behavior -> Workspace" KCM to QML (KDeclarative::ConfigModule) 2- kdeglobals.[KDE].SingleClick configuration should be controlled by two radio buttons from "Desktop Behavior -> Workspace". 3- All the things about "SingleClick" in "plasma-desktop -> kcms -> input" needs to be removed. No need them anymore. This patch will solve Bug 377310 too. Thanks for grabbing this, Furkan! Keep in mind that this needs to ship with Plasma 5.13; we can't ship without a GUI method to change the click settings. The 5.13 branch is created in a little over two weeks, on 2018-05-17, and it would be nice to get it in before then if possible. If not, the latest it can go in is 2018-06-07, which is a little over 5 weeks from now. See https://community.kde.org/Schedules/Plasma_5 What is the status of this issue? A patch is in progress and should be submitted shortly. Git commit d3ef895516fed319956e4ba843206dd118b998f5 by Furkan Tokac. Committed on 17/05/2018 at 19:31. Pushed by furkantokac into branch 'master'. Single/Double Click Option at Workspace KCM Summary: This patch adds the single/double click option to the Workspace KCM. Related: bug 377310 Reviewers: romangg, ngraham, #plasma, mart Reviewed By: romangg, #plasma, mart Subscribers: mart, davidedmundson, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12946 M +3 -0 kcms/workspaceoptions/CMakeLists.txt M +33 -1 kcms/workspaceoptions/package/contents/ui/main.qml M +54 -3 kcms/workspaceoptions/workspaceoptions.cpp M +8 -0 kcms/workspaceoptions/workspaceoptions.h https://commits.kde.org/plasma-desktop/d3ef895516fed319956e4ba843206dd118b998f5 |