Summary: | Color Sliders (HSV) - the Saturation slider does not update when picking a color that has Value 100 | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | trash368031371575 <trash368031371575> |
Component: | Dockers | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | freebox64 |
Priority: | NOR | ||
Version: | 4.0 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://commits.kde.org/krita/6c080e287c014779dca0db974f769a53280916db | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | (Video example) |
Description
trash368031371575
2018-03-16 14:23:28 UTC
Created attachment 111458 [details] (Video example) Yes, I can confirm in Krita 4 - Ubuntu 14.04 as well (see video). Reminder - Open reports I found concerning the "Color Sliders" docker: Bug 352940 (various inaccuracies) Bug 379691 (changing values when switching between documents and back) Bug 385405 (sliders move irrationally with CMYK color model) Can someone fix this please? krita/plugins/dockers/colorslider/kis_color_slider_input.cpp at line 533: if (val==0 || val>0.999) { m_sat = sat_backup; } should be: if (val==0) { Git commit 2e8cf3911ed8dda1884a9991d77b5474be1ca1ca by Boudewijn Rempt. Committed on 28/04/2018 at 11:12. Pushed by rempt into branch 'master'. Make the Saturation slider update when picking a color that has Value 100 M +1 -1 plugins/dockers/colorslider/kis_color_slider_input.cpp https://commits.kde.org/krita/2e8cf3911ed8dda1884a9991d77b5474be1ca1ca Thanks! I've pushed the change. Git commit 6c080e287c014779dca0db974f769a53280916db by Boudewijn Rempt. Committed on 02/05/2018 at 11:54. Pushed by rempt into branch 'krita/4.0'. Make the Saturation slider update when picking a color that has Value 100 (cherry picked from commit 2e8cf3911ed8dda1884a9991d77b5474be1ca1ca) (cherry picked from commit 99ed6c81caa9241adc13f2f292b440ee2991567b) M +1 -1 plugins/dockers/colorslider/kis_color_slider_input.cpp https://commits.kde.org/krita/6c080e287c014779dca0db974f769a53280916db |