| Summary: | Remove "Remember last used Save mode" checkbox in Configure window | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | Nate Graham <nate> |
| Component: | General | Assignee: | Boudhayan Gupta <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andrew.crouthamel, nate, null |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=390793 | ||
| Latest Commit: | https://commits.kde.org/spectacle/d8c78b2934110e7e705e7cbba21945dcddd28f5f | Version Fixed In: | |
| Bug Depends on: | |||
| Bug Blocks: | 390793 | ||
|
Description
Nate Graham
2018-02-20 20:27:29 UTC
Git commit d8c78b2934110e7e705e7cbba21945dcddd28f5f by Nathaniel Graham, on behalf of Roman Inflianskas.
Committed on 22/02/2018 at 17:08.
Pushed by ngraham into branch 'master'.
Remove "Remember last used Save mode" checkbox
Summary:
Per Nate Graham: "This UI control is a relic from a prior version of spectacle when the "Save" split button's menu was full of items. Now, it only has two, and this setting is checked by default. The use case for turning it off is pretty difficult to envision now. Therefore, in the interest of de-cluttering, let's remove it."
Before:
{F5723847}
After:
{F5723849}
Test Plan:
# Select `Save` button.
# Close Spectacle.
# Open Spectacle.
# `Save` is active.
# Select `Save As`.
# Close Spectacle.
# Open Spectacle.
# `Save As` is active.
Reviewers: rkflx, ngraham, #spectacle
Reviewed By: rkflx, ngraham, #spectacle
Subscribers: acrouthamel, ngraham, rkflx
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D10711
M +1 -7 doc/index.docbook
M +2 -8 src/Gui/KSMainWindow.cpp
M +0 -4 src/Gui/KSMainWindow.h
M +0 -9 src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M +0 -1 src/Gui/SettingsDialog/GeneralOptionsPage.h
M +0 -13 src/SpectacleConfig.cpp
M +0 -3 src/SpectacleConfig.h
https://commits.kde.org/spectacle/d8c78b2934110e7e705e7cbba21945dcddd28f5f
|