Summary: | "General" settings page has save-related options that should be on the "Save" page | ||
---|---|---|---|
Product: | [Applications] Spectacle | Reporter: | Eike Hein <hein> |
Component: | General | Assignee: | Boudhayan Gupta <me> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, knutecht, nate, null |
Priority: | NOR | Keywords: | junior-jobs |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=390809 | ||
Latest Commit: | https://commits.kde.org/spectacle/dd493d262d9f2e51a3d57e00388f0ec13e12656f | Version Fixed In: | 18.12.0 |
Bug Depends on: | 390809 | ||
Bug Blocks: |
Description
Eike Hein
2018-02-20 16:25:42 UTC
Thanks Eike, you make a good point, and this is one of the usability issues which is still open. "Remember last used Save mode": Do we actually need this? As we removed "Save & Exit", there are only two options left anyway, and recently we changed the default to "checked". Also, I cannot think of any similar radiobutton-type UI element having a separate config for making it stick or not. "Copy save location to the clipboard": In https://bugs.kde.org/show_bug.cgi?id=390415#c5 we are wondering whether to make this more about "copy to clipboard" and less about "save location". I would be in favor of removing the "Remember last used Save mode" checkbox, as it was mostly useful when the menu was full of items. With only two items and being checked by default... not so much. > removing the "Remember last used Save mode" checkbox
This part would make for a great junior job (should someone ask).
I've split that task out into Bug 390809. I've posted a patch to address this bug: https://phabricator.kde.org/D14812 Git commit 85a0436e7e71f78066ce890fdf1370c202735f56 by Nathaniel Graham. Committed on 03/09/2018 at 22:30. Pushed by ngraham into branch 'master'. Move 'copy file location after saving' to Save Options page Summary: Removed check box for 'copy file location after saving' from General options page and added back to Save options page. Also renamed group box to 'Save Location' and renamed label for default save location to 'Default Save Location' to make the group box title more applicable to the 'copy file location after saving' setting. FIXED-IN: 18.12.0 Before: {F6191546} After: {F6191548} Reviewers: #spectacle, ngraham Reviewed By: #spectacle, ngraham Tags: #spectacle Differential Revision: https://phabricator.kde.org/D14812 M +0 -8 src/Gui/SettingsDialog/GeneralOptionsPage.cpp M +0 -1 src/Gui/SettingsDialog/GeneralOptionsPage.h M +10 -2 src/Gui/SettingsDialog/SaveOptionsPage.cpp M +4 -1 src/Gui/SettingsDialog/SaveOptionsPage.h https://commits.kde.org/spectacle/85a0436e7e71f78066ce890fdf1370c202735f56 Git commit dd493d262d9f2e51a3d57e00388f0ec13e12656f by Nate Graham, on behalf of Kyle Utecht. Committed on 04/09/2018 at 02:14. Pushed by ngraham into branch 'master'. Move 'copy file location after saving' to Save Options page Summary: Removed check box for 'copy file location after saving' from General options page and added back to Save options page. Also renamed group box to 'Save Location' and renamed label for default save location to 'Default Save Location' to make the group box title more applicable to the 'copy file location after saving' setting. FIXED-IN: 18.12.0 Before: {F6191546} After: {F6191548} Reviewers: #spectacle, ngraham Reviewed By: #spectacle, ngraham Tags: #spectacle Differential Revision: https://phabricator.kde.org/D14812 M +0 -8 src/Gui/SettingsDialog/GeneralOptionsPage.cpp M +0 -1 src/Gui/SettingsDialog/GeneralOptionsPage.h M +10 -2 src/Gui/SettingsDialog/SaveOptionsPage.cpp M +4 -1 src/Gui/SettingsDialog/SaveOptionsPage.h https://commits.kde.org/spectacle/dd493d262d9f2e51a3d57e00388f0ec13e12656f |