| Summary: | New tabs should have better title | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | David Hallas <david> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | david, elvis.angelaccio, mail, nate |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 18.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/44a21ea51a055c7429ddee866e35b0a5a21c072b | Version Fixed In: | 18.12.0 |
| Attachments: |
screenshot
tab and window decoration show different titles Tab of pen drive shows weird title |
||
These are just their normal window titles. If you navigate to those sidebar items on their own, you should see the same titles. So this should really be split into multiple bugs requesting better titles for root and network Note: I'm not sure how you could have gotten "baloosearch" from Documents. But "baloosearch" being the window title for all search-related views was recently fixed in https://bugs.kde.org/show_bug.cgi?id=321575 Created attachment 109344 [details]
tab and window decoration show different titles
Normal window titles?
Network for example: tab shows "remote", dolphin window decoration shows "Rede".
"Rede" = "Network" in my language.
Ah, I see what you mean now. looks like this is a broader issue in Dolphin where the titles set for the Sidebar items aren't getting re-used for tab titles. Created attachment 111278 [details]
Tab of pen drive shows weird title
tab title also is not good when I use ctrl+t to open a new tab. For example, open dolphin and click "network" in the sidebar. Now press ctrl+t: now you have two tabs titled "remote". This problem does still exist with Dolphin 18.04.2, confirmed. I am working on implementing this. The solution I am going for is basically to have the tab titles follow the window title, I think that is the most logical. Git commit 44a21ea51a055c7429ddee866e35b0a5a21c072b by David Hallas. Committed on 24/08/2018 at 10:09. Pushed by hallas into branch 'master'. Unify window and tab title Summary: Previously the title of tabs was a prettyfied version of the URL. This is inconsistent with the title of the Window and in some cases for specials URLs kind of misleading. This commit generalizes the code from DolphinMainWindow so that both the DolphinMainWindow title and the tab title uses the same function for the title. This also means that the 'Show Full Path in Title Bar' also applies to the tab title, and also that searches changes the tab title. Test Plan: Open a new tab from the places panel and navigate around. Reviewers: #dolphin, ngraham, elvisangelaccio, markg Reviewed By: #dolphin, ngraham, markg Subscribers: markg, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D14442 M +4 -43 src/dolphinmainwindow.cpp M +2 -3 src/dolphinmainwindow.h M +10 -16 src/dolphintabwidget.cpp M +1 -1 src/dolphintabwidget.h M +47 -0 src/dolphinviewcontainer.cpp M +7 -0 src/dolphinviewcontainer.h https://commits.kde.org/dolphin/44a21ea51a055c7429ddee866e35b0a5a21c072b |
Created attachment 109343 [details] screenshot I think tabs names currently are not good when I open items from the sidebar in a new tab. For example... root shows "/" network shows "remote" documents shows "baloosearch" See the screenshot.