| Summary: | Popups lack close button | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, bugseforuns, n.schnelle, nate |
| Priority: | NOR | Keywords: | usability |
| Version: | 5.41.0 | ||
| Target Milestone: | Not decided | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=388942 | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Getting there... | ||
|
Description
Nate Graham
2017-12-12 01:47:32 UTC
It's what we do on every overlay TBH, they are to be closed by clicking outside. I don't think it's all that weird. I managed to figure it out too, but there wouldn't have been anything to figure out in the first place if there was a close button. :) Also, in cases where the pop-up takes up most of the screen (this is possible with Discover), the click area outside of the pop-up may be rather small. *** Bug 389975 has been marked as a duplicate of this bug. *** It's true that you can always click outside the pop-up, but this has been and will continue to be a source of user confusion and bug reports. We just got our first from a user of Discover on 5.12: https://bugs.kde.org/show_bug.cgi?id=389975 What is obvious to developers is not always obvious to users. Please consider adding close buttons to pop-ups. Git commit fb31f9013b3901ebd40e6bd1343152967911c1c6 by Marco Martin. Committed on 13/02/2018 at 17:00. Pushed by mart into branch 'master'. show a close button on desktop M +16 -0 src/controls/templates/OverlaySheet.qml https://commits.kde.org/kirigami/fb31f9013b3901ebd40e6bd1343152967911c1c6 In Discover we are using QQC2.Popup now for screenshots... Sounds like we'll need to apply a similar patch for Discover, or else re-adopt the Kirigami pop-up. Created attachment 110627 [details]
Getting there...
Getting there! We now have a close button and it works. However, it has some visual and usability issues:
- It doesn't scroll with scrollable content and just stays where it is, which feels weird
- It floats above the darkened area rather than seeming like a part of the pop-up itself
- It doesn't change its visual appearance when hovered or clicked the way most widgets do
With the latest commits, we can call this done. |