| Summary: | Floating dockers not resizable on OS X | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Bernhard Liebl <poke1024> |
| Component: | Dockers | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version: | 4.0 pre-alpha | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | macOS | ||
| Latest Commit: | https://commits.kde.org/krita/1cb9d7fd80ce61b003c311a879e31e4f9d2675f0 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Bernhard Liebl
2017-09-30 15:57:55 UTC
Hm, that's kind of interesting -- we could, perhaps, disable the custom titlebar on OSX, but I'm not sure we can do anything about the actual issue... Yes, disabling the custom titlebar is the only fix in Krita, I looked at the QT code and there's no way to fix it from the outside. I'll look into titlebar disabling on OS X a bit more, it would need to only happen if palettes are floating. I also hope the QT guys take the report seriously, it's a small but highly annoying issue. I think that the chances for the Qt guys working on this bug are remote... It's marked as P3, so we'll need a workaround where all custom titlebar items are removed if the docker is floating. Git commit b662043a20633d3bc52f9b178171a26ef9be532e by Boudewijn Rempt. Committed on 31/03/2018 at 11:06. Pushed by rempt into branch 'master'. Remove the lock, collapse and hide option for dock titlebars On asking around, it seems that even Krita power users were not using these options. New users to Krita seemed unable to grasp this functionality altogether. And we were always having trouble managing the locked and collapsed state of dockers. Note that not having a custom titlebar widget also makes it impossible to keep having an option to remove the titlebars altogether, which was another way to force the dockers to stay in one place. A side-effect is that on macOS, floating dockers are resizable now. Related: bug 392538 CCMAIL:kimageshop@kde.org M +0 -1 krita/krita4.xmlgui M +1 -13 krita/kritamenu.action M +1 -58 libs/ui/KisMainWindow.cpp M +0 -5 libs/ui/KisMainWindow.h M +0 -5 libs/ui/KisViewManager.cpp M +0 -10 libs/ui/kis_config.cc M +0 -3 libs/ui/kis_config.h M +0 -1 libs/ui/widgets/kis_workspace_chooser.cpp M +0 -2 libs/widgets/CMakeLists.txt D +0 -379 libs/widgets/KoDockWidgetTitleBar.cpp D +0 -67 libs/widgets/KoDockWidgetTitleBar.h D +0 -114 libs/widgets/KoDockWidgetTitleBarButton.cpp D +0 -55 libs/widgets/KoDockWidgetTitleBarButton.h D +0 -72 libs/widgets/KoDockWidgetTitleBar_p.h M +0 -5 libs/widgets/KoToolBoxDocker.cpp M +0 -3 libs/widgets/KoToolDocker.cpp M +0 -12 libs/widgets/kritawidgets.qrc D +- -- libs/widgets/pics/dark_docker_close.png D +- -- libs/widgets/pics/dark_docker_collapse_a.png D +- -- libs/widgets/pics/dark_docker_collapse_b.png D +- -- libs/widgets/pics/dark_docker_float.png D +- -- libs/widgets/pics/dark_docker_lock_a.png D +- -- libs/widgets/pics/dark_docker_lock_b.png D +- -- libs/widgets/pics/light_docker_close.png D +- -- libs/widgets/pics/light_docker_collapse_a.png D +- -- libs/widgets/pics/light_docker_collapse_b.png D +- -- libs/widgets/pics/light_docker_float.png D +- -- libs/widgets/pics/light_docker_lock_a.png D +- -- libs/widgets/pics/light_docker_lock_b.png https://commits.kde.org/krita/b662043a20633d3bc52f9b178171a26ef9be532e Git commit 1cb9d7fd80ce61b003c311a879e31e4f9d2675f0 by Boudewijn Rempt. Committed on 03/04/2018 at 11:20. Pushed by rempt into branch 'krita/4.0'. Remove the lock, collapse and hide option for dock titlebars On asking around, it seems that even Krita power users were not using these options. New users to Krita seemed unable to grasp this functionality altogether. And we were always having trouble managing the locked and collapsed state of dockers. Note that not having a custom titlebar widget also makes it impossible to keep having an option to remove the titlebars altogether, which was another way to force the dockers to stay in one place. A side-effect is that on macOS, floating dockers are resizable now. Related: bug 392538 CCMAIL:kimageshop@kde.org (cherry picked from commit b662043a20633d3bc52f9b178171a26ef9be532e) M +0 -1 krita/krita4.xmlgui M +1 -13 krita/kritamenu.action M +1 -58 libs/ui/KisMainWindow.cpp M +0 -5 libs/ui/KisMainWindow.h M +0 -5 libs/ui/KisViewManager.cpp M +0 -10 libs/ui/kis_config.cc M +0 -3 libs/ui/kis_config.h M +0 -1 libs/ui/widgets/kis_workspace_chooser.cpp M +0 -2 libs/widgets/CMakeLists.txt D +0 -379 libs/widgets/KoDockWidgetTitleBar.cpp D +0 -67 libs/widgets/KoDockWidgetTitleBar.h D +0 -114 libs/widgets/KoDockWidgetTitleBarButton.cpp D +0 -55 libs/widgets/KoDockWidgetTitleBarButton.h D +0 -72 libs/widgets/KoDockWidgetTitleBar_p.h M +0 -5 libs/widgets/KoToolBoxDocker.cpp M +0 -3 libs/widgets/KoToolDocker.cpp M +0 -12 libs/widgets/kritawidgets.qrc D +- -- libs/widgets/pics/dark_docker_close.png D +- -- libs/widgets/pics/dark_docker_collapse_a.png D +- -- libs/widgets/pics/dark_docker_collapse_b.png D +- -- libs/widgets/pics/dark_docker_float.png D +- -- libs/widgets/pics/dark_docker_lock_a.png D +- -- libs/widgets/pics/dark_docker_lock_b.png D +- -- libs/widgets/pics/light_docker_close.png D +- -- libs/widgets/pics/light_docker_collapse_a.png D +- -- libs/widgets/pics/light_docker_collapse_b.png D +- -- libs/widgets/pics/light_docker_float.png D +- -- libs/widgets/pics/light_docker_lock_a.png D +- -- libs/widgets/pics/light_docker_lock_b.png https://commits.kde.org/krita/1cb9d7fd80ce61b003c311a879e31e4f9d2675f0 |