Summary: | "Close Description" button has UI/UX issues; should just be a regular back button | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
Component: | discover | Assignee: | Aleix Pol <aleixpol> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, nate |
Priority: | NOR | ||
Version: | 5.9.4 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/discover/d6318b0d0df488cb401964e7607d4dc0ea85a21d | Version Fixed In: | 5.10 |
Description
Nate Graham
2017-03-21 19:23:08 UTC
The issue persists in Discover 5.9.4. Fixed in master, will have a button for that on 5.10. Thanks for reporting and helping make it happen! You're very welcome! I see in 5.10 that there is now a "Close description" button, but this isn't adequate for several reasons: 1. It's in the wrong place: it should be at the top, not the bottom. Back buttons go on top as a standard UI convention. 2. It has an arrow the points to the right, not the left. Back buttons always point to the left. 3. Only the arrow is clickable, not the text. The click/touch area is very small. 4. The text "Close description" is ambiguous. It should just be a regular back button with the word "Back". Git commit d6318b0d0df488cb401964e7607d4dc0ea85a21d by Aleix Pol. Committed on 20/09/2017 at 14:03. Pushed by apol into branch 'master'. Add a header into the ApplicationPage Removes the clashing with the controls when it's compact. Solves some issues with the current close control M +150 -180 discover/qml/ApplicationPage.qml https://commits.kde.org/discover/d6318b0d0df488cb401964e7607d4dc0ea85a21d Much better! Just a few remaining niggles, which I'll track individually with new tickets to avoid torturing this poor bug report. - https://bugs.kde.org/show_bug.cgi?id=384912 [patch submitted] - https://bugs.kde.org/show_bug.cgi?id=384913 - https://bugs.kde.org/show_bug.cgi?id=384914 [patch submitted] Also submitted a patch for https://bugs.kde.org/show_bug.cgi?id=384913 |