Bug 376345

Summary: can't disable "auto spell check" while editing metadata
Product: [Applications] digikam Reporter: csaba zsadányi-nagy <rhadath>
Component: Usability-SpellCheckAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 4.14.0   
Target Milestone: ---   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 8.0.0
Sentry Crash Report:
Attachments: digikam metadata editor screenshot with spell checker option

Description csaba zsadányi-nagy 2017-02-11 11:30:51 UTC
Created attachment 103976 [details]
digikam metadata editor screenshot with spell checker option

every time i restart digikam, the "auto spell check" checkbox is selected in the metadata description editor (title, captions), no matter how many times i deselect it. global kde setting (regional settings -> spell check -> automatic spell checking enabled by default) is off. i haven't found a way to disable spell check in digikam once and for all. it's not too serious, but annoying
Comment 1 caulier.gilles 2017-02-11 14:38:19 UTC
Since digiKam 5.0.0, we remove a lots of KDE dependencies to become step by step more a pure Qt5 application (it stil 20% of KDE API use currently).

This problem do not exist anymore.

https://www.flickr.com/photos/digikam/32023589633/in/dateposted-public/

Gilles Caulier
Comment 2 csaba zsadányi-nagy 2017-02-11 15:06:40 UTC
> This problem do not exist anymore.

that's a great news! thanks a lot. i hope it will be updated soon in *ubuntu lts releases
Comment 3 caulier.gilles 2017-02-11 15:12:23 UTC
You can use Linux AppImage bundle that we provide. This install nothing. It's safe.

You can test pre-version here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 4 caulier.gilles 2022-08-15 20:09:01 UTC
Git commit 1cbabe037c7b19c0c0ede596e4da59c88b9dced9 by Gilles Caulier.
Committed on 15/08/2022 at 20:08.
Pushed by cgilles into branch 'master'.

Add methods to active or not the spell-checking in common digiKam text edit classes.

M  +62   -0    core/libs/widgets/text/dtextedit.cpp
M  +20   -0    core/libs/widgets/text/dtextedit.h

https://invent.kde.org/graphics/digikam/commit/1cbabe037c7b19c0c0ede596e4da59c88b9dced9
Comment 5 caulier.gilles 2022-08-16 05:52:18 UTC
Git commit 1df6bb1dd102230858e657cca219dbc888e77319 by Gilles Caulier.
Committed on 16/08/2022 at 05:51.
Pushed by cgilles into branch 'master'.

Add 2 new classes to host spell check settings

M  +2    -0    core/libs/widgets/CMakeLists.txt
A  +67   -0    core/libs/widgets/text/spellcheckcontainer.cpp     [License: GPL (v2+)]
A  +66   -0    core/libs/widgets/text/spellcheckcontainer.h     [License: GPL (v2+)]
A  +140  -0    core/libs/widgets/text/spellchecksettings.cpp     [License: GPL (v2+)]
A  +83   -0    core/libs/widgets/text/spellchecksettings.h     [License: GPL (v2+)]

https://invent.kde.org/graphics/digikam/commit/1df6bb1dd102230858e657cca219dbc888e77319
Comment 6 caulier.gilles 2022-08-16 09:21:35 UTC
Git commit 42525afb9c790e10c13f660902bfc46081e52588 by Gilles Caulier.
Committed on 16/08/2022 at 09:20.
Pushed by cgilles into branch 'master'.

Introduce Spell Check settings configuration view in digiKam Setup/Miscs.
The view only host the single option to turn on/off the spell-checking in background.
All text edit widget supported spell-checking are affected by this change without to re-start application.
More options/info about spell-checking will be hosted in this view.
This view will be also appended to Showfoto/Setup later to be homogeneous.

M  +1    -0    core/libs/widgets/CMakeLists.txt
M  +32   -4    core/libs/widgets/text/dtextedit.cpp
M  +4    -10   core/libs/widgets/text/dtextedit.h
A  +121  -0    core/libs/widgets/text/spellcheckconfig.cpp     [License: GPL (v2+)]
C  +14   -23   core/libs/widgets/text/spellcheckconfig.h [from: core/utilities/setup/setupmisc.h - 058% similarity]
M  +1    -1    core/libs/widgets/text/spellcheckcontainer.h
M  +39   -5    core/utilities/setup/setupmisc.cpp
M  +2    -1    core/utilities/setup/setupmisc.h

https://invent.kde.org/graphics/digikam/commit/42525afb9c790e10c13f660902bfc46081e52588
Comment 7 caulier.gilles 2022-08-16 12:27:04 UTC
Git commit ab1537d0dd663a670a9073fa76849b5da9fba248 by Gilles Caulier.
Committed on 16/08/2022 at 12:25.
Pushed by cgilles into branch 'master'.

Introduce Spell Check settings configuration view in Showfoto Setup/Miscs.

M  +36   -0    core/showfoto/setup/showfotosetupmisc.cpp
M  +2    -1    core/showfoto/setup/showfotosetupmisc.h
M  +1    -1    core/utilities/setup/setupmisc.cpp

https://invent.kde.org/graphics/digikam/commit/ab1537d0dd663a670a9073fa76849b5da9fba248
Comment 8 caulier.gilles 2022-08-16 12:55:50 UTC
Git commit 8a85052ec1b215db0013ab5856dcd89c7b4b7506 by Gilles Caulier.
Committed on 16/08/2022 at 12:54.
Pushed by cgilles into branch 'master'.

Add label to give more explainations about how spellcheck work

M  +18   -10   core/libs/widgets/text/spellcheckconfig.cpp

https://invent.kde.org/graphics/digikam/commit/8a85052ec1b215db0013ab5856dcd89c7b4b7506
Comment 9 caulier.gilles 2022-08-16 17:20:45 UTC
Git commit 09e9acc42caf0d6bab9631e8ea287f728bf51cec by Gilles Caulier.
Committed on 16/08/2022 at 17:19.
Pushed by cgilles into branch 'master'.

Spell Checking config widget: show backend and dictionary lists.
FIXED-IN: 8.0.0

M  +2    -21   core/libs/dialogs/libsinfodlg.cpp
M  +1    -0    core/libs/widgets/CMakeLists.txt
M  +84   -6    core/libs/widgets/text/spellcheckconfig.cpp

https://invent.kde.org/graphics/digikam/commit/09e9acc42caf0d6bab9631e8ea287f728bf51cec
Comment 10 caulier.gilles 2022-08-17 03:09:02 UTC
Git commit fb9bc61ea2cc4d5045d7adde54d3b03bc59e888f by Gilles Caulier.
Committed on 17/08/2022 at 02:59.
Pushed by cgilles into branch 'master'.

If user change a current language from an alternative language text edit widget,
and if the language is not "x-default", force spell-checker to use this language as well.

If user change a current language from an alternative language text edit widget to "x-default",
turn on the auto-detection of language in spell-checker.

Note: By default, an alternative language text edit widget always use the auto-detection of language in spell-checker.
Related: bug 200223

M  +5    -1    core/libs/widgets/metadata/utils/altlangstredit.cpp
M  +56   -10   core/libs/widgets/text/dtextedit.cpp
M  +2    -0    core/libs/widgets/text/dtextedit.h
M  +2    -2    core/libs/widgets/text/spellcheckconfig.cpp
M  +5    -5    core/libs/widgets/text/spellcheckcontainer.cpp
M  +2    -1    core/libs/widgets/text/spellcheckcontainer.h

https://invent.kde.org/graphics/digikam/commit/fb9bc61ea2cc4d5045d7adde54d3b03bc59e888f
Comment 11 caulier.gilles 2022-08-17 20:01:32 UTC
Git commit 613ed81b09651aee468c6d663fa32fed2c392ca9 by Gilles Caulier.
Committed on 17/08/2022 at 19:55.
Pushed by cgilles into branch 'master'.

Spell-Checking: add settings to ignore a list of words.
Related: bug 92310, bug 200223, bug 256471, bug 360954, bug 402922

M  +1    -0    core/app/main/digikamapp.cpp
M  +1    -0    core/app/main/digikamapp_p.h
M  +10   -0    core/libs/widgets/text/dtextedit.cpp
M  +166  -11   core/libs/widgets/text/spellcheckconfig.cpp
M  +6    -2    core/libs/widgets/text/spellcheckconfig.h
M  +13   -5    core/libs/widgets/text/spellcheckcontainer.cpp
M  +3    -2    core/libs/widgets/text/spellcheckcontainer.h
M  +4    -1    core/libs/widgets/text/spellchecksettings.cpp
M  +1    -0    core/showfoto/main/showfoto.cpp
M  +1    -0    core/showfoto/main/showfoto_p.h

https://invent.kde.org/graphics/digikam/commit/613ed81b09651aee468c6d663fa32fed2c392ca9