| Summary: | new network manager configuration model is unreadable | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | John Salatas <jsalatas> |
| Component: | kcm_networkmanagement | Assignee: | Lukáš Tinkl <lukas> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hrvoje.senjan, jgrulich, kde |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-nm/9351665935c1b01a27415926ac4c85c9329f133a | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Network Connections List
New Network Connection Patch to fix unreadable items in new network manager configuration model |
||
Created attachment 103347 [details]
New Network Connection
I don't think there is anything I can do, I use standard colors from both like plasma theme and application colors. I bet you have similar problem with KCM for windows decoration or with KScreen KCM. Hmmm..... it doesn't seem that I have similar issues elsewhere. :\ However it reminds me a similar issue that I had with the kickoff configuration buttons: https://phabricator.kde.org/D2900 and https://phabricator.kde.org/D2884 Is this qml related? If so, maybe I can have a look at it. I'm not too comfortable with C++ code yet :( Yes it is QML related, you can find the part you are interested in kcm/qml directory. Created attachment 103362 [details]
Patch to fix unreadable items in new network manager configuration model
Please have a look at the attached patch. It seems that it correctly handles all cases of scheme/desktop theme combinations, although the result isn't (always) aesthetically pleasant :\
I tried it with both breeze light (theme + app color) and breeze dark (theme + app color) and I don't like any of them. Better would be to discuss this with other plasma people on plasma-devel + with VDG I guess. OK. I guess we need to create a differential review in phabricator... *** Bug 374976 has been marked as a duplicate of this bug. *** *** Bug 375058 has been marked as a duplicate of this bug. *** John, can you please post your patch as review in phabricator? Review created https://phabricator.kde.org/D4153 Git commit e0e8f0608af1910885a7a011b082d533e1fd3c46 by Jan Grulich. Committed on 16/01/2017 at 09:17. Pushed by grulich into branch 'master'. KCM: Do not use Plasma components as the colors are not consistent M +1 -0 kcm/CMakeLists.txt M +5 -0 kcm/kcm.cpp M +8 -6 kcm/qml/ConnectionItem.qml M +12 -13 kcm/qml/Dialog.qml M +3 -2 kcm/qml/Header.qml A +93 -0 kcm/qml/ListItem.qml [License: LGPL] M +9 -13 kcm/qml/main.qml https://commits.kde.org/plasma-nm/e0e8f0608af1910885a7a011b082d533e1fd3c46 Git commit 9351665935c1b01a27415926ac4c85c9329f133a by Jan Grulich. Committed on 16/01/2017 at 09:17. Pushed by grulich into branch 'Plasma/5.9'. KCM: Do not use Plasma components as the colors are not consistent M +1 -0 kcm/CMakeLists.txt M +5 -0 kcm/kcm.cpp M +8 -6 kcm/qml/ConnectionItem.qml M +12 -13 kcm/qml/Dialog.qml M +3 -2 kcm/qml/Header.qml A +93 -0 kcm/qml/ListItem.qml [License: LGPL] M +9 -13 kcm/qml/main.qml https://commits.kde.org/plasma-nm/9351665935c1b01a27415926ac4c85c9329f133a |
Created attachment 103346 [details] Network Connections List I'm using Breeze light application schemeand Breeze Dark desktop theme and under this combination the new network manager configuration model is unreadable (see atrtached screenshots).