| Summary: | Tool-Tip Text is Unreadable In File and digiKam Properties | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | hardy.public |
| Component: | Usability-Themes | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, dev, metzpinguin, wwwutz |
| Priority: | NOR | ||
| Version: | 5.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/digikam/f142f9fb87be3132ed7aea071e3a321c084ad302 | Version Fixed In: | 6.0.0 |
| Sentry Crash Report: | |||
| Attachments: |
Image of problem.
screenshot crop of file properties hover window |
||
|
Description
hardy.public
2016-10-10 20:43:31 UTC
Created attachment 101516 [details]
Image of problem.
Which color scheme theme do you use in Settings menu ? Gilles Caulier Thanks for the hint. I was only using Default but I just tried all the themes. Most are unreadable, some are partially readable, and 3 are OK. So for now, I'll just use one I can read. Not Readable. White font on light background. Default Black Body DarkRoom High Key White Balance Difficult To Read. Light gray font on light background. SunsetColor GrayCard Readable. Dark gray font on light background. LowKey ShadeOfGray ColorContrast *** Bug 382367 has been marked as a duplicate of this bug. *** Created attachment 109185 [details]
screenshot crop of file properties hover window
file properties window with default theme with unreadable colors.
This is still an issue in 5.8.0 build http://commits.kde.org/digikam/7f1c8a4ba87362587d825dd8a727eba7fe281e85 (In reply to Peter Marquardt from comment #6) > This is still an issue in 5.8.0 build > http://commits.kde.org/digikam/7f1c8a4ba87362587d825dd8a727eba7fe281e85 Peter, do you use the Windows version? I get the feeling this is only a problem on Windows. I also get the feeling this is not simple to resolve. Personally I would settle for an additional 'Windows' theme where a any workable combination, however ugly, could be found to allow tool-tip text and icons to be readable at the same time and forego any aesthetic beauty. yes exactly. This problem exist only with non X11 platform, as MacOS and Windows. The color theme are constructed under under Linux with X11 composite. The port to other platform are just given for testing. the color theme are text files description and can be adjusted easily. If you found the right values for Windows, we can customize the code to wrap themes accordingly with OS. Note : The widget style as also a side effect on the color rendering. It's a big puzzle. This is why we only provide one widget style for MacOS and Windows. Under Linux all work as expected. Note2 : The color theme engine come from KDE core with some improvements done in digiKam core. There are complex algorithms inside. The problem can be also in these implementations (as i'm sure that KDE dev has never tested these implementation outside Linux). https://cgit.kde.org/digikam.git/tree/libs/widgets/mainview/schememanager.cpp Gilles Caulier (In reply to caulier.gilles from comment #8) > the color theme are text files description and can be adjusted easily. If > you found the right values for Windows, we can customize the code to wrap > themes accordingly with OS. Thanks Gilles. If you tell me which text files to change I'm happy to experiment and propose some values. (In reply to caulier.gilles from comment #8) > yes exactly. This problem exist only with non X11 platform, as MacOS and > Windows. Sorry forgot to mention: Windows port. > https://cgit.kde.org/digikam.git/tree/libs/widgets/mainview/schememanager.cpp Thanks for he pointer, I'm setting up a configure-make-make-install session 8-) For me it looks as if the background color of the tool tip is not changed at all. We have the same problem under Windows with the DWizardDlg (QWizard) tools. The theme color is not included here. Maik The colors scheme files are defined here : https://cgit.kde.org/digikam.git/tree/data/colorschemes Under Windows, the files are copied as well on the install path (see data/digikam/ sub-dir), and can be easily customized with a text editor. You can create a new one, it will be automatically proposed in digiKam at next restart. The new created file must be stored at the same place than others one of course. Note : The color scheme files are managed by the schememanager.cpp class in background to render color on GUI. Gilles Caulier (In reply to caulier.gilles from comment #12) > Under Windows, the files are copied as well on the install path Yep found them in C:\Program Files\digiKam\data\digikam\colorschemes But these are the optional theme colors, not the default 8( Is there a way to export the "Default" ? And make it load "default.colors" on startup when there is no user theme defined ? Maybe something like "only use hardcoded defaults when there is no default.colors found" ? Git commit f142f9fb87be3132ed7aea071e3a321c084ad302 by Maik Qualmann. Committed on 03/12/2017 at 12:12. Pushed by mqualmann into branch 'master'. fix wrong colors in the tooltip under Windows FIXED-IN: 5.8.0 M +2 -1 NEWS M +0 -2 libs/widgets/itemview/ditemtooltip.cpp https://commits.kde.org/digikam/f142f9fb87be3132ed7aea071e3a321c084ad302 Yes, definitely fixed in 7-Dec build. Thanks guys! Just installed 5.9.0 and the issue is back. No need to take a screenshot, since it's exactly the same. This problem is now fixed in digiKam-6.0.0 beta1. https://files.kde.org/digikam/ If you want to test the beta, make a backup of the database if you want to go back. Maik |