Bug 370247

Summary:	Folders thumbnails : custom folder icon overridden by default folder icon
Product:	[Frameworks and Libraries] kio-extras	Reporter:	Mahendra Tallur <mahen>
Component:	default	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	samrog131
Priority:	NOR
Version:	5.8.4
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Mahendra Tallur 2016-10-07 12:44:53 UTC

When using a custom icon, previews and especially folders previews being enabled, if the directory contains pictures, the directory icon is replaced by the default folder icon.

Reproducible: Always

Steps to Reproduce:
1. Create a directory and put a couple of pictures inside of it.
2. In Dolphin settings, make sure thumbnails are enabled for directories
3. Switch the view mode to icons and enable previews
4. Change the icon of the directory with a custom one (any icon from the default set will do : for instance folder-videos)

Actual Results:  
The icon of the created directory will display previews of pictures it contains, over the default folder icon.

Expected Results:  
The icon of the created directory should consist of the pictures previews above the custom icon selected beforehand.

Using KDE Neon (october 2016 image) ; KDE Framework 5.26.

Comment 1 Mahendra Tallur 2016-12-12 11:44:43 UTC

Hi ! Just updating after testing with latest KDE / Apps / Neon revisions. Bug still occurs.

But I'm not sure I'm filing the bug at the right place. What component is actually responsible for displaying icons ? 

Thanks :)

Comment 2 Rog131 2016-12-13 10:46:34 UTC

(In reply to Mahendra Tallur from comment #1)
> Hi ! Just updating after testing with latest KDE / Apps / Neon revisions.
> Bug still occurs.
> 
> But I'm not sure I'm filing the bug at the right place. What component is
> actually responsible for displaying icons ? 
> 
> Thanks :)

By my knowledge the kio-extras. Folder thumbnailing is using the icon theme directory icon. ie:

https://cgit.kde.org/kio-extras.git/  ->  /kio-extras/thumbnail/thumbnail.cpp
has, from line 466:

//Use the current (custom) folder icon
const QMimeDatabase db;
const QString iconName = db.mimeTypeForName("inode/directory").iconName();

const QPixmap folder = QIcon::fromTheme(iconName).pixmap(qMin(m_width, m_height));

Comment 3 Mahendra Tallur 2016-12-13 12:22:03 UTC

OK, I moved the bug and changed its name. Notifications are still being sent to Dolphin maintainers though, do I have something else to do ? Thanks a lot :)

Comment 4 Mahendra Tallur 2016-12-14 15:24:42 UTC

Hmm, it looks like it might be a one-line fix (not sure :-). 

If I could easily set up a development environment in a virtual machine. Any pointer ? If stumbled upon this : https://community.kde.org/Get_Involved/development but I'd need a tutorial indicating how to make changes to core components & test them, from the Neon Dev edition it would probably be even more relevant. Well, I'll look again !

Comment 5 Mahendra Tallur 2017-01-20 09:50:57 UTC

I'm closing this and creating another report in the right area because I think something went wrong and the bug was not assigned to the right person :-) I hope you don't mind !

*** This bug has been marked as a duplicate of bug 375333 ***

Comment 6 Christoph Feck 2017-01-20 12:37:17 UTC

In the future, please do not do this. We can reassign bugs.

Comment 7 Mahendra Tallur 2017-01-20 13:00:08 UTC

Yes, sorry about this :( 

Actually I changed the "product" field but it didn't change the "referee" so the relevant persons didn't receive the notification (I guess ?).

Was there another way to do this ?

Thanks and sorry again for the inconvenience !

Comment 8 Christoph Feck 2017-01-23 03:45:52 UTC

If you change either product or component, the checkbox "Reset Assignee to default" should automatically get checked. If not, you might need to click the "(edit)" link next to "Assignee", and check this option manually.

But this time it is our fault, because we missed comments #3.

Comment 9 Mahendra Tallur 2017-01-23 08:39:08 UTC

@Christoph : thanks for your replies. I'm pretty sure there is no "edit" button next to "assignee", I am probably not allowed to do it as a regular user.

Comment 10 Christoph Feck 2017-01-25 02:10:27 UTC

Okey, I reported bug 375528 for this issue. Hopefully it reflects what was going on.