| Summary: | Improve usability of "Open with > Other" file dialog | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Simone Gaiarin <simgunz> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, codestruct, colesen, kdelibs-bugs, maurizio.colucci, MurzNN, nate, sibskull, simonandric5, sladivadi, sudrien, visual-design |
| Priority: | NOR | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kio/e3af26bbb1e7dd32a7bb48c615d352416066e238 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Show the two entries of kate.
Mockup of the open with dialog Improve caption and text |
||
|
Description
Simone Gaiarin
2016-02-10 13:38:46 UTC
Created attachment 97134 [details]
Show the two entries of kate.
If we associate the file with the "kate" command two entries of kate are shown in the "Open with.." menu, and one of those doesn't have an icon (because it's a command).
Could you actually involve the visual design group and tell me what to implement? I volunteer to implement what you come up with, but not to take part in lengthy discussions :) PS: I implemented https://bugs.kde.org/show_bug.cgi?id=110146, see link to screenshot there. Thanks for the interest. I've actually opened a topic in the VDG section of the forum, but for now the discussion haven't received much interest. Let's wait a bit and see if someone post something there. https://forum.kde.org/viewtopic.php?f=285&t=131014 Created attachment 97317 [details]
Mockup of the open with dialog
My two cents on how to implement the solution:
See attached mockup first.
* Set window title to the file name without the full path (see red circle in mockup)
* Add "Advanced section" to hide terminal options (see mockup)
* Line edit should behave like this:
* When the user start typing the know applications are filtered out leaving only the ones that match the query
* It can also behave as a terminal to run a command, but I would activate the dropdown suggestion list of commands only if the user presses "arrow down". The current behavior of showing it as the user starts typing will let it hide the known application list underneath. In this way the know application list is considered the way of choosing the application with highest priority, while the terminal command is a secondary option.
In any case let's wait for the VDG suggestions, otherwise I suggest to implement as I described if none has anything against it.
Window title: the filename is actually a bit hard to see, and the sentence "Open with:" underneath is a bit terse. How about something like Windows does? http://www.bleepstatic.com/tutorials/windows-7/change-file-associations/choose-program.jpg Rather have a terse caption and an explanatory sentence like that, no? Created attachment 97592 [details]
Improve caption and text
Here's what my current code leads to.
Git commit 2e652f99ad069188f96f7f070579996a13e9a4f6 by David Faure. Committed on 13/03/2016 at 23:33. Pushed by dfaure into branch 'master'. KOpenWithDialog: improve window title and description text M +11 -8 src/widgets/kopenwithdialog.cpp M +1 -1 src/widgets/kopenwithdialog.h M +6 -6 src/widgets/krun.cpp M +2 -2 tests/kopenwithtest.cpp http://commits.kde.org/kio/2e652f99ad069188f96f7f070579996a13e9a4f6 I've submitted a patch to solve the point number 3, app tree filtering. https://git.reviewboard.kde.org/r/130179/ Git commit 0296b89714ce96b247322d9be09b387573d79193 by David Faure, on behalf of Simone Gaiarin. Committed on 15/07/2017 at 12:53. Pushed by dfaure into branch 'master'. Make advanced options of "open with" dialog collabsible and hidden by default The current "open with" dialog implementation does not follow the KDE principle "Simple by default, powerful when needed" for the following reasons: - The "run in terminal" and "keep terminal open" options are advanced options and should not be exposed by default - The primary goal of the dialog should be to select an application from the app tree, running command is an advanced feature My patch changes the behavior as follow: * Put the two options in a KCollapsibleComboBox collapsed by default * The user can expand it only if he needs to use a command line command Implementation details: - When the KCollapsibleComboBox is clicked it is expanded upward keeping the dialog size fixed and compressing the treeview, I'm not sure this is the best approach, but to make it expand downwards we need to fix the size of the dialog with setSizeConstraint(QLayout::SetFixedSize); which may not be desiderable. Maybe there is a way to keep the dialog resizable and expand the combobox downwards, but I couldn't find it. - I've increased the vertical size of the dialog (which I think it was too small) also to accomodate the upward expansion which otherwise would make the app tree almost disappear Relevant discussions: https://forum.kde.org/viewtopic.php?f=285&t=131014 REVIEW: 130180 M +24 -11 src/widgets/kopenwithdialog.cpp https://commits.kde.org/kio/0296b89714ce96b247322d9be09b387573d79193 @David Faure Have you had a look at the other review request regarding this bug? The one on tree filtering. https://git.reviewboard.kde.org/r/130179/ Simone, if you are still interested to contribute your improvements, I suggest to upload the patch to https://phabricator.kde.org/differential/diff/create/ Unfortunately we had to abandon the old reviewboard site. I'm trying to submit the patch to phabricator using arcanist and I have some questions: - Who should I set as reviewer? In the phabricator guide they say to set a hashtag with the name of the project but searching for the project "kio" I don't get results on phabricator. so what is the name of the project? - Are there a list of keywords to use in the arc commit message? As an example one to say which bug is fixed by this patch? I'm using arcanist instead of the patch form because the modification includes 7 commits, and I think it is going to be way harder to review if I squash everything in a single patch. I'm not familiar with arcanist, but I hope it preserves the different commits with their messages. Nice work! Does this also have the effect of fixing https://bugs.kde.org/show_bug.cgi?id=377322? Ah, I see that it does, since my duplicate entries are actually commands, not app items. *** Bug 377322 has been marked as a duplicate of this bug. *** And for people's easy reference, the Phabricator revision is at https://phabricator.kde.org/D8056 *** Bug 358139 has been marked as a duplicate of this bug. *** Git commit e3af26bbb1e7dd32a7bb48c615d352416066e238 by Henrik Fehlauer, on behalf of Simone Gaiarin. Committed on 14/02/2018 at 17:19. Pushed by rkflx into branch 'master'. Improve usability of "Open With" dialog by adding option to filter the application tree Summary: The current "open with" dialog implementation does not follow the KDE principle "Simple by default, powerful when needed" for the following reasons: - The current primary goal of the lineedit is to type in a command. Indeed when start typing a drop-down list with command auto-completion appears. Usability problems: - The mentioned drop-down list covers the application tree - It's not possible to search in the application tree, so to find a software it is necessary to guess the category every time My patch changes the behavior as follow: Simple by default: - The primary goal of the lineedit is to be a search box that allows to filter the applications in the tree - The command auto-completion is disabled by default Powerful when needed - The command autocompletion can be turned on by advanced users by selecting the preferred autocompletion mode in the right click context menu of the lineedit (this behavior is quite hidden, and I guess most of the normal users don't even know it's possible (I didn't know it until I dig into the code)) Implementation details: - The application tree filtering is achieved using a subclass of QSortFilterProxyModel - When 3 characters are typed in the search box all the tree is expanded (there should be few matching entries at this point) - When the 3rd character is deleted all the tree is collapsed - In order to be able to filter, it's necessary to fetch all the tree nodes when the model is created, and not on demand as it was before. This is achieved by adding a fetchAll method. Maybe there is a more elegant way. I've tested the implementation, but I'm pretty sure I haven't covered all the possible cases, so a careful testing is necessary. Relevant discussions: https://forum.kde.org/viewtopic.php?f=285&t=131014 Test Plan: Tests done: With and without some text in the line edit: - Double click on category opens it - Double click on entry launches the software - Remember program association for mime works - Run in terminal works - Keep open terminal works Reviewers: dfaure, #frameworks, #vdg, ngraham, rkflx Reviewed By: dfaure, ngraham, rkflx Subscribers: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D8056 M +138 -24 src/widgets/kopenwithdialog.cpp M +2 -0 src/widgets/kopenwithdialog.h M +16 -1 src/widgets/kopenwithdialog_p.h https://commits.kde.org/kio/e3af26bbb1e7dd32a7bb48c615d352416066e238 *** Bug 167424 has been marked as a duplicate of this bug. *** *** Bug 337264 has been marked as a duplicate of this bug. *** *** Bug 110871 has been marked as a duplicate of this bug. *** *** Bug 118799 has been marked as a duplicate of this bug. *** *** Bug 212030 has been marked as a duplicate of this bug. *** *** Bug 80355 has been marked as a duplicate of this bug. *** |
