Bug 357490

Summary:	Razor cursor inaccurately looks like clip will be cut to right of scissors
Product:	[Applications] kdenlive	Reporter:	Kubuntiac <user581>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	minor	CC:	paul, qubodup, wegwerf-1-2-3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Cut icon for the light theme dk_edit-cut.png Dark theme icon SVG Light theme version SVG

Description Kubuntiac 2016-01-04 01:23:48 UTC

When choosing the razor tool, it shows a pair of scissors with a black line to the right. The black line seems to imply that when clicked, the tool will cut the clip where the black line is. In reality, it cuts somewhat to the left of that in the middle of the pair of scissors. This would actually be a good thing, if the vertical line was actually placed there, too.

From a UX point of view this cursor should really show a dotted line running through the center of the scissors, and no line to the right.

I actually went to create this myself, but was unable to track down the razor_cursor.png file or it's SVG. If anyone can point me to either (preferably the SVG) I'm more than happy to create the updated version myself.

Reproducible: Always

Steps to Reproduce:
1. Click on the razor tool
2. Click on a clip in the timeline
3. Notice where the clip cuts relative to the cursor

Actual Results:  
Clip cuts in the middle of the scissors

Expected Results:  
Clip cuts where the vertical line is, or better yet, that the vertical line in the cursor exists where the clip currently cuts (in the middle of the scissors)

Comment 1 Jean-Baptiste Mardelle 2016-01-04 09:50:59 UTC

Thanks for the report. The black line is indeed a bug in the icon.
Icons are here:

/data/pics/breeze-light/lt_edit-cut.svgz
and
/data/pics/breeze-dark/dk_edit-cut.svgz

patches welcome

Comment 2 qubodup 2016-01-04 14:17:37 UTC

@Kubuntiac thanks for offering to help! Perhaps you could also try to assist with https://bugs.kde.org/show_bug.cgi?id=356509 (it refers to the "Chroma Key" effect).

In my case, the cursor doesn't change at all when using the razor tool, I'll file a separate ticket for that.

Comment 3 Kubuntiac 2016-01-04 17:33:16 UTC

Created attachment 96450 [details]
Cut icon for the light theme

The line in the centre better shows the user where the cut will actually take place.

Comment 4 Kubuntiac 2016-01-04 17:36:39 UTC

Created attachment 96451 [details]
dk_edit-cut.png

Version for the dark theme

Comment 5 Kubuntiac 2016-01-04 17:37:49 UTC

Created attachment 96452 [details]
Dark theme icon SVG

Comment 6 Kubuntiac 2016-01-04 17:38:16 UTC

Created attachment 96453 [details]
Light theme version SVG

Comment 7 Jean-Baptiste Mardelle 2016-01-04 22:56:00 UTC

Git commit ad15c59a4043c10ef5a59b1877e971d767db6ac9 by Jean-Baptiste Mardelle.
Committed on 04/01/2016 at 22:55.
Pushed by mardelle into branch 'master'.

Add vertical line to clearly show cut position in timeline
Related: bug 357529

M  +50   -0    src/timeline/customtrackview.cpp
M  +4    -0    src/timeline/customtrackview.h

http://commits.kde.org/kdenlive/ad15c59a4043c10ef5a59b1877e971d767db6ac9

Comment 8 Jean-Baptiste Mardelle 2016-01-04 22:58:37 UTC

Thanks for your work. However, after discovering bug #357529 (adding a vertical line in timeline to show cut position), I think it is a better option since at full zoom it can offer frame precision while the cursor icon cannot.

I implemented a test in git master

Comment 9 Kubuntiac 2016-01-05 00:25:46 UTC

No problem. I just wanted to be able to clearly see where the cut would happen. This is even better, so I'm happy!

Comment 10 Paul Konecny 2016-01-06 22:22:01 UTC

Just tested your "test". Looks and works great!
Thanks J-B!