Created attachment 96449 [details] three mockups of what the suggested line might look like When cutting, I sometimes get unsure where the clip will cut once I click. I have to trace my cursor position vertically upwards and then horizontally to conclude from the cursor's position where the cut will happen once I press the left mouse button. A vertical line in the timeline would help. Please see attached mockup images. Suggested color values The color could be the color of text (usually black in light-background themes) or the color of the lines at the top of the timeline (where the time codes are), 80% opacity for track that would be affected by you clicking right now (track under cursor) 25% opacity for tracks that would not be affected by you clicking right now One color solution might work for all zoom levels. At zoom levels where one frame is thinner than one pixels, it might still be an acceptable approximation indicator.
Git commit ad15c59a4043c10ef5a59b1877e971d767db6ac9 by Jean-Baptiste Mardelle. Committed on 04/01/2016 at 22:55. Pushed by mardelle into branch 'master'. Add vertical line to clearly show cut position in timeline Related: bug 357490 M +50 -0 src/timeline/customtrackview.cpp M +4 -0 src/timeline/customtrackview.h http://commits.kde.org/kdenlive/ad15c59a4043c10ef5a59b1877e971d767db6ac9
Created attachment 96462 [details] Razor line indicator
I implemented it in a slightly different way - a red line the height of the current track - see my attached image. It is in git master, I let you try and comment.
Whoops found the right bug repport just now. Anyway this works great and looks the part!
I agree. Works awesome!
I agree too: very good UI improvement. Small but important. Many thanks!
Thanks, this is very nice. I have found a few issues and have suggestions. I'll report the issues here and suggestions later in new tickets if that's all right with you. I) Cutting indicator wrong size across vertical zoom levels Steps: 1. Enable razor 2. Zoom track vertically Expected: 1. Red line resizes with track height Actual: 1. Red line keeps same height. Images: http://imgur.com/a/knltD II) Pressing "x" jumps red line to left Steps: 1. Move mouse to timeline 2. Press x Expected: 1. Red line is under cursor Actual: 1. Red line is at 0:00 2. Moving mouse fixes it. Video: https://www.youtube.com/watch?v=GMY4KbhPfZc III) Moving on the right side of a frame indicates it will cut on the right (next frame) but if you click, it cuts on the left (hovered frame). Premiere CC 2015 indicates & cuts what is closer. Final Cut Pro indicates & cuts what is on the left (current frame). Kdenlive currently indicates left but cuts closer. Steps: 1. Have clip in timeline 2. Press x 3. Cut clips while the cursor is close to the left (beginning) of a frame or close to the right (end) of a frame Expected: 1. The cut happens where the line is drawn Actual: 1. The cut is always on the left (at the beginning of the hovered frame) Video: https://youtu.be/nLJSTFtJkco
Git commit 594b7b2512a86f9642365006a115f52a8ba897d1 by Jean-Baptiste Mardelle. Committed on 11/01/2016 at 23:29. Pushed by mardelle into branch 'master'. Fix several issues with razor tool cut line preview M +6 -5 src/timeline/customtrackview.cpp http://commits.kde.org/kdenlive/594b7b2512a86f9642365006a115f52a8ba897d1
The indicator is great now. I would prefer a razor cursor icon and the cut position to be at the top left of the cursor but that's a topic for another feature request issue.