Bug 353227

Summary:	[Polish] Consider making the "Find" toolbar botton a toggle-able button.
Product:	[Applications] dolphin	Reporter:	Hussam Al-Tayeb <ht990332>
Component:	search	Assignee:	Scott Harvey <scott>
Status:	RESOLVED DUPLICATE
Severity:	wishlist	CC:	bugseforuns, elvis.angelaccio, humanix, nate, pmargeti34, scott
Priority:	NOR
Version:	16.12.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Hussam Al-Tayeb 2015-09-27 07:59:54 UTC

If I open /home/hussam and press the "Find" button in the toolbar, it opens a search bar but the button itself doesn't get into a 'pressed' state. This is ok but it is nicer in terms of polish to put the button in a pressed stated while the search bar is open. This makes the product looks more polished since users like visual feedback.
As an advantage, the [x] button in the search bar can be optionally removed if the above is implemented because I can instead toggle off the search bar. This also minimizes the buttons on the screen.
Thank you.

Reproducible: Always

Comment 1 Nate Graham 2017-09-03 05:19:45 UTC

I rather agree.

Comment 2 Scott Harvey 2018-04-08 16:55:53 UTC

FYI - there's also menu item `Edit -> Find (Ctrl+F)`, which should probably toggle the state of the `Find` button as well. It performs the same action (showing the Find bar).

I'm working on this and will fix the menu item as well, unless there's an objection.

Comment 3 Patrick Silva 2018-04-21 18:22:19 UTC

*** Bug 392796 has been marked as a duplicate of this bug. ***

Comment 4 Nate Graham 2018-04-21 19:25:08 UTC

There have been a few patches that attempted to do this, but they've all run into some issues. Heres the latest one: https://phabricator.kde.org/D12094

Comment 5 fire f. 2018-06-11 19:41:43 UTC

I say: dump the whole FIND button and use KFIND instead via right-click: 

https://bugs.kde.org/show_bug.cgi?id=395255

Comment 6 Elvis Angelaccio 2019-05-19 08:29:22 UTC


*** This bug has been marked as a duplicate of bug 344617 ***