| Summary: | Crash when applying auto lens correction (chromatic aberration) [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | C. Priisholm <claus.priisholm> |
| Component: | Plugin-Editor-LensCorrection | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 4.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/a0ea63613faf5062e6891eb12d53b334b1babc4a | Version Fixed/Implemented In: | 4.9.0 |
| Sentry Crash Report: | |||
| Attachments: |
getsubpixelcolorfast.patch
getsubpixelcolorfast2.patch |
||
|
Description
C. Priisholm
2015-03-15 07:56:43 UTC
Here is the raw file causes the crash: http://www.codedroids.dk/pub/DSC01972.ARW In terms of the lens info that one is shot with SONY / ILCE-5000 / E PZ 16-50mm F3.5-5.6 OSS I've provided two other images, shot with different lenses. In both cases I can apply the lens correction - incl. chromatic aberration - without crashing digiKam: http://www.codedroids.dk/pub/DSC01754.ARW - SONY / ILCE-5000 / E 30mm F2.8 and http://www.codedroids.dk/pub/DSC01925.ARW - SONY / ILCE-5000 / E 55-210mm F4.5-6.3 OSS So it does seem the problem is limited to certain lenses If the test images already uploaded? I get a file not found error. Maik Sorry, they were in the wrong folder - please try again. Yes with the image DSC01972.ARW crashes the lenses correction... RAW image is open in 16 bits color depth or 8 bits ? There is a difference between import mode ? As backtrace said, perhaps there is a problem while pixels processing. Gilles Another possible cause, the pixels image size is not well taken from this RAW image metadata. Gilles Created attachment 91573 [details]
getsubpixelcolorfast.patch
Coordinates of lfModifier ::ApplySubpixelDistortion(...) can be negative. It must be caught in DImg::getSubPixelColorFast(...).
Git commit a0ea63613faf5062e6891eb12d53b334b1babc4a by Gilles Caulier. Committed on 15/03/2015 at 23:21. Pushed by cgilles into branch 'master'. Apply patch # 91573 from Maik Qualmann to wrap image pixel positions to image sizes when Lens Corrections are applied by LensFun. Related: bug 333540, bug 319383 FIXED-IN: 4.9.0 M +4 -1 NEWS M +22 -13 libs/dimg/dimg.cpp http://commits.kde.org/digikam/a0ea63613faf5062e6891eb12d53b334b1babc4a Git commit 53fd2de987febf552103de3ecc910a4d9c94c0d2 by Gilles Caulier. Committed on 15/03/2015 at 22:47. Pushed by cgilles into branch 'frameworks'. backport commit #a0ea63613faf5062e6891eb12d53b334b1babc4a from git/master to frameworks branch Related: bug 333540, bug 319383 M +16 -7 libs/dimg/dimg.cpp http://commits.kde.org/digikam/53fd2de987febf552103de3ecc910a4d9c94c0d2 Created attachment 91583 [details]
getsubpixelcolorfast2.patch
I think with this patch it is perfect.
Maik
Git commit 2a0a710fb2b92a0b6115f329799a40a9dec8aeb9 by Gilles Caulier. Committed on 16/03/2015 at 22:19. Pushed by cgilles into branch 'master'. apply patch #91583 from MAik Qualmann M +8 -7 libs/dimg/dimg.cpp http://commits.kde.org/digikam/2a0a710fb2b92a0b6115f329799a40a9dec8aeb9 Git commit 6713c4088e19bacbf990992be2c2bd98b5aa03eb by Gilles Caulier. Committed on 16/03/2015 at 22:27. Pushed by cgilles into branch 'frameworks'. backport commit #2a0a710fb2b92a0b6115f329799a40a9dec8aeb9 from git/master M +8 -7 libs/dimg/dimg.cpp http://commits.kde.org/digikam/6713c4088e19bacbf990992be2c2bd98b5aa03eb |