Bug 342685

Summary: Places continually reset
Product: [Frameworks and Libraries] frameworks-kbookmarks Reporter: illumilore <illumilore>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: critical CC: alexander.stehlik, alexis.gm, cfeck, diego.ml, email, emmanuelpescosta099, gandalflechner, gilberto.nunes32, gustavo, jarlgjessing, kaabud-kde, karsten.htw, kde, maxim.yegorushkin, mrboese, nortexoid, nx.devnull, rdieter, simonandric5, sudhir, vermontpoet, yoggic, zanetu
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In: 14.12.3
Sentry Crash Report:
Attachments: Duplicate entries in "Save as" dialog

Description illumilore 2015-01-10 07:56:03 UTC
After bookmarking a new place to the places panel, after rebooting the machine, the saved places reset, leaving only home, root, network, and trash.

Reproducible: Always




dolphin 4.14.3-4.6

opensuse 13.2
Comment 1 Christoph Feck 2015-01-10 17:28:14 UTC
Since when? It is obviously not reproducible here, so it might be your setup. Can you try with a freshly created user account?
Comment 2 Kai Uwe Broulik 2015-01-10 22:36:58 UTC
For a couple of days I experience a similar issue running Dolphin frameworks branch. My places don't clear but their order is lost with the ones I added (Downloads, Projects, Data, Ftp shares etc) appearing at the end of the list, with some entries even removed. Unfortunately I haven't figured out a pattern so far.
Comment 3 illumilore 2015-01-10 23:40:59 UTC
It started happening about 4 days ago I think, and happened with a new account. I also noticed that my samba passwords memory reset about the same time, but those still seem to not reset after every reboot.
Comment 4 Frank Reininghaus 2015-01-18 21:49:29 UTC
Does this also happen if you do not use Dolphin at all, but add new Places using the "Open File..." dialog of, e.g., KWrite, and then re-boot and open the dialog again?
Comment 5 Gilberto Ferreira 2015-01-25 14:51:34 UTC
Hi guys

I have the same situatuion here...

I am using:

Distributor ID: Ubuntu
Description:    Ubuntu Vivid Vervet (development branch)
Release:        15.04
Codename:       vivid
Comment 6 Emmanuel Pescosta 2015-01-25 15:09:00 UTC
(In reply to Gilberto Ferreira from comment #5)
> Hi guys
> 
> I have the same situatuion here...

Can you please verify if the same problem exists in the open/save dialog as well? (see comment #4)
Thanks!

@Everyone
Do you use KDE connect? Does the reordering/removing of places happen after KDE connect decives come and go from the places panel?
Comment 7 illumilore 2015-01-25 17:18:29 UTC
The problem hasn't happened for me since an update a week or two ago, although the order of the entries did change from what I had it once. I have noticed that when I have two dolphin windows open, adding or removing entries will duplicate on the other open window but not when you change the order of places.
Comment 8 Karsten 2015-02-07 20:36:15 UTC
I have the same problem on my Arch (64bit) machine! It's happen in Dolphin and in "Open file ..." dialogs (e.g. KWrite, Transmission-Qt and Gwenview).

I'm using Plasma 5 and the Qt4 version of Dolphin from the officially Arch extra repo. The version is "14.12.2" (https://www.archlinux.org/packages/extra/x86_64/kdebase-dolphin/), but in the help menu in Dolphin I can see the version number "14.11.97".

I doesn't use KDE Connect!

I noticeable this problem after I migrate (two days ago) from KDE Plasma 4 to Plasma 5.
Comment 9 Gilberto Ferreira 2015-02-07 20:39:12 UTC
Sometimes it works...

I bookmarking the places and everything is ok for two or three days... But when I power off my system and power on again, they disappear....

Very weird...
Comment 10 Karsten 2015-02-07 20:54:35 UTC
For me, It's happened not only when I power off my system and power on again. It's happen SOMETIMES when I for example close and reopen Dolphin or when I open the contextmenu in Dolphin or when I suspend (RAM) and "restart" (from the suspend) my system.

It happened during many different situations.
Comment 11 Emmanuel Pescosta 2015-02-07 21:00:04 UTC
> It's happen in Dolphin and in "Open file ..." dialogs (e.g. KWrite, Transmission-Qt and Gwenview). 

Thanks for the info, so the problem is most likely somewhere in KBookmarks, because all these applications use the same lib to access/modify bookmarks.
Comment 12 Karsten 2015-02-07 22:53:37 UTC
Ok, thanks.

If you need more informations or if you need someone for testing a patch or anything else, please contact me. But I can't programming, I'm a "normal" user.
Comment 13 David Edmundson 2015-02-08 13:12:46 UTC
*** Bug 343735 has been marked as a duplicate of this bug. ***
Comment 14 alexis.gm 2015-02-09 06:44:22 UTC
It happens to me as well.   I am running kubuntu 14.10 with plasma 5.2.    The bookmarks seem to randomly disappear every day or two.   Sometimes because of a reboot, but not necessarily.
Comment 15 Alain Laporte 2015-02-12 01:42:33 UTC
It happens even without to restart Dolphin. All places are suddenly disappeared juste after add another one.
Comment 16 Emmanuel Pescosta 2015-02-19 19:31:04 UTC
Git commit 2a79feaea0088730bbf4fd4b65baa1c4a91b84b9 by Emmanuel Pescosta. 
Committed on 19/02/2015 at 19:05. 
Pushed by emmanuelp into branch 'Applications/14.12'. 

Sync bookmark manager only if the change was done by the current process 

Adoption of http://commits.kde.org/kdelibs/2b5c6e42fc8114c6854ce490b9cdd4356be683d9 

FIXED-IN: 14.12.3 
Related: bug 310080 
REVIEW: 122640 

M +0 -20 dolphin/src/panels/places/placesitemmodel.cpp 
M +8 -13 dolphin/src/panels/places/placesitemmodel.h 
M +5 -0 dolphin/src/panels/places/placespanel.cpp 

http://commits.kde.org/kde-baseapps/2a79feaea0088730bbf4fd4b65baa1c4a91b84b9
Comment 17 Emmanuel Pescosta 2015-02-22 11:50:51 UTC
*** Bug 344444 has been marked as a duplicate of this bug. ***
Comment 18 Michael D 2015-03-23 20:55:52 UTC
This is supposed to be fixed in 14.12.3, but for me it isn't. Dolphin is still forgetting Places changes after restarting dolphin. I'm running Kubuntu 15.04 with latest updates as of 23 March.
Comment 19 Emmanuel Pescosta 2015-03-23 21:35:05 UTC
(In reply to Michael D from comment #18)
> This is supposed to be fixed in 14.12.3, but for me it isn't. Dolphin is
> still forgetting Places changes after restarting dolphin. I'm running
> Kubuntu 15.04 with latest updates as of 23 March.

Thanks for your feedback!
Please have a lookt at https://bugs.kde.org/show_bug.cgi?id=345174
Comment 20 Guillaume Debray 2015-05-02 12:02:21 UTC
Same problem here, Kubuntu 15.04 and Dolphin 14.12.3 
Kubuntu Backports activated with ppa.
Comment 21 Gustavo Boksar 2015-05-03 02:35:42 UTC
I've just install over an existing home partition of Kubuntu 15.04 / vivid repo (KDE 4.14.6 and Dolphin 14.12.3), and places won't remain after closing dolphin window.
Then I tried creating a new user and problem remains.
Same happens at open/save dialog.

I've also tried a installing from scratch in a VM and same problem... new places won't reamain after closing dolphin window.
Comment 22 Christoph Feck 2015-05-03 08:07:48 UTC
Gustavo, see bug 345174.
Comment 23 PGillespie 2015-05-04 23:34:07 UTC
Happening to me too. Soon as I close Dolphin, any additions to Places vanishes. 

KDE 4.14.6
Kubuntu 15.04
Comment 24 Christoph Feck 2015-05-05 08:43:42 UTC
See bug 345174.
Comment 25 Jarl Gjessing 2015-05-07 10:51:49 UTC
I have the same problem on Kubuntu 15.04, Dolphin 14.03
I edited the bookmarks.xml and I located my location:
 <bookmark href="file:///home/jarl/Documents/">
  <title>Documents</title>
  <info>
   <metadata owner="http://freedesktop.org">
    <bookmark:icon name="inode-directory"/>
   </metadata>
   <metadata owner="http://www.kde.org">
    <ID>1430995767/8 (V2)</ID>
    <isSystemItem>true</isSystemItem>
   </metadata>
  </info>

I then added the line:
<isSystemItem>true</isSystemItem>
and now it is present each time I open dolphin

So, it appears as if it ignores non system items.
Comment 26 Christoph Feck 2015-05-07 11:32:43 UTC
See bug 345174.
Comment 27 Maxim Egorushkin 2015-05-14 19:25:10 UTC
Same issue in Fedora 21 with
dolphin-libs-15.04.0-1.fc21.x86_64
dolphin-15.04.0-1.fc21.x86_64
Comment 28 Rex Dieter 2015-05-14 20:38:25 UTC
Re: comment #27
fedora 21 still uses plasma4, this bug was about using dolphin on plasma5.  which are you using?
If plasma5, the fix landed in dolphin-15.04.0-3
Comment 29 Maxim Egorushkin 2015-05-14 21:14:34 UTC
(In reply to Rex Dieter from comment #28)
> Re: comment #27
> fedora 21 still uses plasma4, this bug was about using dolphin on plasma5. 
> which are you using?
> If plasma5, the fix landed in dolphin-15.04.0-3

I use stock plasma4. 

Did not notice plasma5, apologies.
Comment 30 Alexander Stehlik 2015-05-21 13:20:15 UTC
(In reply to jarlgjessing from comment #25)

> I then added the line:
> <isSystemItem>true</isSystemItem>
> and now it is present each time I open dolphin

I can confirm that this solution works. I change the file that is located at:

~/.kde/share/apps/kfileplaces/bookmarks.xml
Comment 31 Gandalf Lechner 2015-05-26 15:16:58 UTC
Same bug here (kubuntu 15.04, fully updated). Editing bookmarks.xml helps for showing the places in dolphin, but not in krunner (with search "places" activated).
Comment 32 Nikola Kovacs 2015-06-10 09:21:50 UTC
I have the same problem on Kubuntu 15.04 with kde-apps 15.04.1 in Kate.
Dolphin (which uses KDE Development Platform 4.14.8) works fine and shows "home" in places. Kate (5.0.0 using frameworks 5.9.0 according to the about box) does not show "home" in places (I think it disappeared when I upgraded to kde-apps 15.04.1 from the backports repository). If I add it back, it disappears after a while (it's completely inconsistent, sometimes it's there after I close and open kate, sometimes not, sometimes if I open a new kate instance it's there, sometimes not).
Comment 33 Emmanuel Pescosta 2015-06-10 09:35:42 UTC
(In reply to Nikola Kovacs from comment #32)
> I have the same problem on Kubuntu 15.04 with kde-apps 15.04.1 in Kate.
> Dolphin (which uses KDE Development Platform 4.14.8) works fine and shows
> "home" in places. Kate (5.0.0 using frameworks 5.9.0 according to the about
> box) does not show "home" in places (I think it disappeared when I upgraded
> to kde-apps 15.04.1 from the backports repository). If I add it back, it
> disappears after a while (it's completely inconsistent, sometimes it's there
> after I close and open kate, sometimes not, sometimes if I open a new kate
> instance it's there, sometimes not).

Please upgrade to KIO >= 5.10
Comment 34 Diego 2015-07-08 12:15:27 UTC
(In reply to Emmanuel Pescosta from comment #6)
> (In reply to Gilberto Ferreira from comment #5)
> > Hi guys
> > 
> > I have the same situatuion here...
> 
> Can you please verify if the same problem exists in the open/save dialog as
> well? (see comment #4)
> Thanks!
> 
> @Everyone
> Do you use KDE connect? Does the reordering/removing of places happen after
> KDE connect decives come and go from the places panel?

Hi Emmanuel,

KDE Platform 4.14.9 on Fedora 21 with all the updates. I'm experiencing every kind of weird problems:
- adding folder to Places panel is unbearably slow and freezes Dolphin for several seconds;
- the "Save As" dialog has tons of duplicated entries (see attachment);
- I deleted ~/.kde/share/apps/kfileplaces/ but it got recreated;
- I experienced a crash that might be related to this problem (see bug #350023).

And yes, I'm using KDE Connect.

Sorry for mixing up so many things, if you think I need to open up separate bugs, just tell me.
Comment 35 Diego 2015-07-08 12:19:41 UTC
Created attachment 93525 [details]
Duplicate entries in "Save as" dialog

A lot of duplicate entries appear in "Save as" dialog. The same entries are not displayed in Dolphin.
Comment 36 Rex Dieter 2015-07-08 12:25:42 UTC
Sorry to add confusion, but mention of Fedora 21, see 
https://admin.fedoraproject.org/updates/FEDORA-2015-8922

where the changes introduced here were reverted, due to regressions seen when using plasma4 (vs running kde4 apps on plasma5):
https://bugzilla.redhat.com/show_bug.cgi?id=1228340
Comment 37 Diego 2015-07-08 12:58:44 UTC
(In reply to Rex Dieter from comment #36)
> Sorry to add confusion, but mention of Fedora 21, see 
> https://admin.fedoraproject.org/updates/FEDORA-2015-8922
> 
> where the changes introduced here were reverted, due to regressions seen
> when using plasma4 (vs running kde4 apps on plasma5):
> https://bugzilla.redhat.com/show_bug.cgi?id=1228340

I confirm I had kdelibs-4.14.9-2.fc21.x86_64.

Discussing with Rex I tried the following procedure:
1) log out KDE;
2) remove (or rename/move, if you want backup) ~/.kde/share/apps/kfileplaces/
3) log back in.

This solved the duplicate entries in the "Save as" dialog and the slowness of adding a new entry.

So probably I entered a weird state after the patch has been reverted, using the above procedure brought me out of the "bad loop".