| Summary: | digiKam don't compile with next Lensfun version where CCI correction have been removed | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Marc Cousin <cousinmarc> |
| Component: | Portability-Compilation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, veaceslav.munteanu90 |
| Priority: | NOR | ||
| Version: | 4.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/2ad23dae290c64c293d9c3d3ae2c8734c99f902b | Version Fixed In: | 4.3.0 |
| Sentry Crash Report: | |||
|
Description
Marc Cousin
2014-02-26 09:07:39 UTC
The question is why CCI Feature (Lens Color Contribution) have been removed from Lensfun ? I cannot see any comment about in commit message... Gilles Caulier No idea. I just tried to compile latest digikam with latest lensfun (because I wanted to see if the bug 330943 was there too). Removing code from digiKam to drop CCI features is easy. I want to be sure that CCI is really removed and why, before to touch code from digiKam lensfun interface Gilles Caulier http://developer.berlios.de/forum/message.php?msg_id=97629 I guess that, as nobody objected… :) Hello, I tried to compile digikam 4.2.0 with lensfun svn snapshot today and it failed due to the same problem as above... :-( i want to use latest lensfun because my camera support has been added there... best regards Frantisek Fero, When is planed next lensfun release without CCI feature ? Gilles Caulier Hi Gilles, I'm sorry, I have no idea when next version of lensfun will be released ;-). I checked on their website, mailing list but found no info... Fero Git commit 2ad23dae290c64c293d9c3d3ae2c8734c99f902b by Gilles Caulier. Committed on 02/09/2014 at 15:06. Pushed by cgilles into branch 'master'. Make digiKam ready to use next Lensfun API where CII correction have been removed. Related: bug 319383, bug 333540 FIXED-IN: 4.3.0 M +1 -2 imageplugins/enhance/lensautofixtool.cpp M +1 -1 imageplugins/enhance/lensautofixtool.h M +3 -12 libs/dimg/filters/lens/lensfunfilter.cpp M +3 -5 libs/dimg/filters/lens/lensfunfilter.h M +3 -6 libs/dimg/filters/lens/lensfuniface.cpp M +0 -1 libs/dimg/filters/lens/lensfuniface.h M +1 -26 libs/dimg/filters/lens/lensfunsettings.cpp M +1 -2 libs/dimg/filters/lens/lensfunsettings.h M +8 -13 utilities/queuemanager/basetools/enhance/lensautofix.cpp M +1 -1 utilities/queuemanager/basetools/enhance/lensautofix.h http://commits.kde.org/digikam/2ad23dae290c64c293d9c3d3ae2c8734c99f902b Hi Gilles, compiled successfully - current lensfun git clone with digikam 4.3.0 many thanks! keep up the great job! ;-) Best regards Fero Current master do not compile with lensfun 0.3.0-1
the same error:
error: 'LF_MODIFY_CCI' was not declared in this scope
modifyFlags |= LF_MODIFY_CCI;
Oops.. A mistake from my side :) |