| Summary: | kruler should be able to stay above all other windows | ||
|---|---|---|---|
| Product: | [Applications] kruler | Reporter: | Martin Koller <kollix> |
| Component: | general | Assignee: | Alexander Neundorf <neundorf> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | KrazyKyngeKorny, manuel11g, mike, neundorf, ofnuts, simonandric5 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch for always on top
Patch for always on top v2 |
||
|
Description
Martin Koller
2013-03-27 12:26:48 UTC
The workaround is to press Alt+F3 to get the window menu. Created attachment 78945 [details]
Patch for always on top
Hi,
I've seen a junior issue assigned for this so I've tried to make it.
I've made in the context menu a new sub-menu called layer where I added 2 options - Always on top layer and Normal layer. When one is selected the other one is set to disable.
Also I've set the default behavior Always on top.
Hope it's good,
Manuel
Comment on attachment 78945 [details]
Patch for always on top
I suggest that you do it with just one checkable action "Keep Above Others" as it is done in the kwin menu. For a boolean flag, there is no need to have a submenu and two actions.
To the patch - this part is wrong:
QLatin1String( "length_short" )
and
Qt::Key_N, QLatin1String( "length_medium" )
It seems a copy/paste error from another action.
Created attachment 78972 [details]
Patch for always on top v2
Hi,
I've took in consideration your comment and I've made a new patch. I've made only one check able actionset in the main context menu. Also I've added the functionality to save the user choice
Thank you for your help..
Comment on attachment 78972 [details]
Patch for always on top v2
+ KMenu *mLayerMenu;
This seems no longer needed.
But as I'm not the maintainer, please create a review request at reviewboard.kde.org
Thanks for your work!
*** Bug 303366 has been marked as a duplicate of this bug. *** *** Bug 332106 has been marked as a duplicate of this bug. *** I also discovered that while in the advanced selection of the Alt-F3 menu you can turn on the borders. KrazyKyngeKorny (Krazy, not stupid) On Thu, Mar 13, 2014 at 2:00 PM, Christoph Feck <christoph@maxiom.de> wrote: > https://bugs.kde.org/show_bug.cgi?id=317436 > > Christoph Feck <christoph@maxiom.de> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |KrazyKyngeKorny@gmail.com > > --- Comment #7 from Christoph Feck <christoph@maxiom.de> --- > *** Bug 332106 has been marked as a duplicate of this bug. *** > > -- > You are receiving this mail because: > You are on the CC list for the bug. > to comment #8: I can not reproduce this with 4.13beta2 (but in fact it is not directly related to this issue) *** Bug 208947 has been marked as a duplicate of this bug. *** Actually in KDE 3 kruler was always on top. What I'm doing now is adding a special kwin rule for kruler :-/ Looking at the commit logs it looks like kruler is more or less unmaintained. I committed a modified version of the attached patch, it is now a setting in the settings dialog, see http://commits.kde.org/kruler/ab152c2f7ee07cd3eb8f10b902ebeff1b4b6e182 . Thanks a lot! Very appreciated! *** Bug 377502 has been marked as a duplicate of this bug. *** |