| Summary: | Some icons of symlinks folders are bigger than others | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Frank Souza <franksouza183> |
| Component: | view-engine: icons mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | emmanuelpescosta099 |
| Priority: | NOR | ||
| Version: | 4.11.2 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| URL: | http://i.imgur.com/mBZsF.png | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/b892058730544d53e0c08e32dc297f2f1256f9ae | Version Fixed In: | 4.13.0 |
| Sentry Crash Report: | |||
|
Description
Frank Souza
2012-11-24 04:01:54 UTC
Another information: Happens between the minimum zoom to zoom up to 96 px Thanks for the bug report, I can reproduce this. Seems to be related to the length of the file name. Still reproducible? I can't reproduce it in Dolphin 4.11.0. I cannot reproduce either. Please reopen if you see the problem again in Dolphin 4.11.2 or later. Thanks! The problem persists Ubuntu 12.04 Dolphin 4.11.2 Watch: http://www.youtube.com/watch?v=dkyIbayy1wM Thanks for your immediate feedback and for the video! I think I have an idea about what might be going wrong. Could you please try the following: In a different folder, create a regular file or folder with the same name that one of the symlinks that gets such a huge icon has. If you use exactly the same view settings, could it be that the non-symlink needs one more line of text below the icon than the symlink? If my assumption is true, then the problem is that KStandardItemListWidgetInformant::itemSizeHint(int index, const KItemListView* view) calculates the number of lines required for the item's name based on the metrics of the non-italic font. When the view tries to render the item on the screen, it uses the italic font and finds that needs less space than it reserved earlier for the item, and then uses the excess space to show a bigger icon. Similar bugs are bug 326210 (about incorrect text rendering for symlinks in Compact View), bug 308022 and bug 323841 (which are about the view drawing a blurry icon because the reserved height for the item is 1 pixel less than is actually needed). Review-Request: https://git.reviewboard.kde.org/r/116121/ Can someone, who can reproduce this bug, please test if this patch fixes the problem? Thanks! What version was this fixed? Oh, I see, 4.13. I'll wait for updates, then I can test...sorry again. 4.12.2 here Git commit b892058730544d53e0c08e32dc297f2f1256f9ae by Emmanuel Pescosta. Committed on 05/03/2014 at 09:48. Pushed by emmanuelp into branch 'KDE/4.13'. Fix Bug 326210 - Dolphin unnecessarily truncates names of soft links in compact mode FIXED-IN: 4.13.0 Related: bug 326210 REVIEW: 116121 M +18 -0 dolphin/src/kitemviews/kfileitemlistwidget.cpp M +2 -0 dolphin/src/kitemviews/kfileitemlistwidget.h M +31 -5 dolphin/src/kitemviews/kstandarditemlistwidget.cpp M +12 -0 dolphin/src/kitemviews/kstandarditemlistwidget.h http://commits.kde.org/kde-baseapps/b892058730544d53e0c08e32dc297f2f1256f9ae @Frank Souza: Thanks for your help! Feel free to reopen this bug report if you can reproduce it in 4.13.0 ;) |
