| Summary: | Rename "View Image" to "Preview". | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Dotan Cohen <kde-2011.08> |
| Component: | Preview-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, smit.meh |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/82dfdf1c0ed12fe0560de4743ea3ecc5722257c8 | Version Fixed In: | 2.7.0 |
| Sentry Crash Report: | |||
|
Description
Dotan Cohen
2012-06-26 14:08:30 UTC
Hi Dotan, Gilles What do you think? If its fine with you, I can find the required code and patch it. Smit Agree. View->View Image menu entry is typo redondant. View->Preview Image is fine. No need a patch here in Bugzilla. Please patch directly git/master (not 3.0.0 branch). Commit will be backported to 3.0.0 later... Don't forget to patch NEWS file too... Gilles Caulier Git commit 82dfdf1c0ed12fe0560de4743ea3ecc5722257c8 by Smit Mehta. Committed on 26/06/2012 at 19:42. Pushed by smitmehta into branch 'master'. Fixing typo. View Image -> Preview Image M +1 -1 NEWS M +1 -1 digikam/main/digikamapp.cpp http://commits.kde.org/digikam/82dfdf1c0ed12fe0560de4743ea3ecc5722257c8 Smit, You miss to patch icon-view Context Menu where there is a "View" action which is used to switch in preview mode... Gilles Caulier Gilles, I changed the line 843 of digikam/main/digikamapp.cpp. I think that only governs the name of that action. However even I am surprised that it didnt change anything. When I used grep on the digiKam directory, i didnt see any other code affecting that. Any ideas? Smit Context menu action is here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/items/digikamimageview.cpp#L327 Gilles Caulier Git commit f699376e285d3e81b79a788c32182a9b49d61edb by Smit Mehta. Committed on 27/06/2012 at 09:11. Pushed by smitmehta into branch 'master'. context menu typo fix. view->preview M +1 -1 digikam/items/digikamimageview.cpp http://commits.kde.org/digikam/f699376e285d3e81b79a788c32182a9b49d61edb |