Summary: | Make add face persistent, and add box by single click instead of drawing [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | 20120808_bugs.kde.org |
Component: | Faces-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | caulier.gilles, kristian.hermann.karl, mr.mahon.pl |
Priority: | NOR | ||
Version: | 2.5.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.11.0 | |
Sentry Crash Report: | |||
Attachments: | Suggested patch |
Description
20120808_bugs.kde.org
2012-02-16 10:00:50 UTC
Only a savings of three steps? from eleven to eight in this example? not enough savings? How about again showing mouse movements (I have not seen a keyboard shortcut for 'add a face tag'): Actual Results: 1) move mouse toward 'add a face tag' button 2) click 'add a face tag' 3) move mouse down toward face 4) draw a box around the first face 5) move mouse up toward 'add a face tag' button 6) click 'add a face tag' 7) move mouse down toward face 8) draw a box around the second face 9) move mouse up toward 'add a face tag' button 10) click 'add a face tag' 11) move mouse down toward face 12) draw a box around the third face 13) 'forward' to next picture 14) move mouse up toward 'add a face tag' button 15) click 'add a face tag' 16) move mouse down toward face 17) draw a box around the first face 18) move mouse up toward 'add a face tag' button 19) click 'add a face tag' 20) move mouse down toward face 21) draw a box around the second face Expected Results: 1) move mouse up toward 'add a face tag' button 2) click 'add a face tag' 3) move mouse down toward faces 4) click the first face; box is drawn automatically 5) adjust box as needed 6) move mouse toward next face 7) click second face 8) move mouse up toward next face 9) click third face 10) 'forward' to next picture 11) move mouse toward next face 12) click first face 13) move mouse toward next face 14) click second face Created attachment 72719 [details]
Suggested patch
I also feel that the proposed workflow will help when manually face tagging.
I made a suggested patch that I think may work, but I would like to get some feed back.
What I did was changing the 'Add a Face Tag' button into a toggle button instead, pretty much as the 'Show Face Tags' toggle button works.
Nit-picking, I would like to add that "adjust box as needed" is two steps, drag upper left corner, drag lower left corner, after each single click. See also #329433 I meant bug https://bugs.kde.org/show_bug.cgi?id=329433 Kristian, Can you update your patch with current implementation from git/master (currently next 4.3.0) ? Thanks in advance Gilles Caulier I just update https://bugs.kde.org/show_bug.cgi?id=329433 It's the same patch, that I proposed for this bug. As patch from bug #329433 is already applied to git/master, and as explained in comment #7, the patch is the same, we can close this file now. Gilles Caulier Wouldn't adding a keyboard shortcut for "Add a face tag" help a lot? I think it would speed things up a lot: 1. press the key shortcut 2. click one corner of the box 3. click the opposite corner of the box 4. [next face] press the key shortcut 5. click one corner of the box 6. click the opposite corner of the box etc. [alternatively: moving to the next picture with the keyboard] With mouse in one hand and keyboard under the other it would be really smooth. You should be able to do the following. When ready to add a face tag: 1. Press and hold the Ctrl-key 2. Click and hold left mouse button where you want the corner of your face tag 3. Move the mouse to the other corner, and release the mouse button. Did this help you? (In reply to Kristian Karl from comment #10) > You should be able to do the following. > When ready to add a face tag: > 1. Press and hold the Ctrl-key (...) > > Did this help you? I forgot about this, even though I used it a lot. But then I encounter a problem: After tagging a face, when I start tagging another one, the previous box(es) dissapears. I need to disable the "show face tags" mode and re-enable it to see the boxes again. But I think it's a different error. Thanks for the help! > I forgot about this, even though I used it a lot. > But then I encounter a problem: > > After tagging a face, when I start tagging another one, the previous box(es) > dissapears. > I need to disable the "show face tags" mode and re-enable it to see the > boxes again. > > But I think it's a different error. > Thanks for the help! I checked and yes, it's a different error: https://bugs.kde.org/show_bug.cgi?id=334244#c8 |