| Summary: | Guess Tags from file name does not save results into Track Details Dialog | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Sebastian Körner (Mailings) <s.koerner.mailings> |
| Component: | Metadata Editing and Reading | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | amantia, hkariti, m35371, sven.burmeister |
| Priority: | NOR | ||
| Version: | 2.4-GIT | ||
| Target Milestone: | 2.4.1 | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.5 | |
| Sentry Crash Report: | |||
|
Description
Sebastian Körner (Mailings)
2011-01-25 23:54:49 UTC
*** Bug 264632 has been marked as a duplicate of this bug. *** I have also experienced this bug. Amarok version 2.4.1-3 (Archlinux) I am able to reproduce it only when "Use Full File Path" is enabled under "Guess Tags from filename" - i.e. Steps to Reproduce: Right click a music file in the collection (tried on .wav and .mp3) Edit Track Details > Guess Tags from filename > Use full file path (with reasonable depth) > Reasonable filename scheme > OK As reported, even though the result preview shows the correct tags, changes are not reflected in the track details. The feature seems to work fine (on my setup) when not using full file path. You are aware that *.wav files do not have id3 tags, aren't you? Yes, I am aware of that, but I'm able to change Track Details under Amarok manually for my wav files, and Amarok remembers these changes - I haven't figured out how they are tagged. The bug is still valid for mp3 files though. (In reply to comment #1) > *** Bug 264632 has been marked as a duplicate of this bug. *** I only just noticed that you have marked bug 264632 as a duplicate of this bug. To clarify - the problem being faced in this bug is that the track details are not updated from the Guess Tag from file name feature (ie tags for a single file are not being changed). The other bug seems to be about multiple files being edited at the same time. Can these two be addressed as separate bugs? Why? those are clearly related. (In reply to comment #6) > Why? those are clearly related. Not really. bug 264632 reports problems in the Guess Tags from Filename *dialog*, limiting its usefulness when tagging multiple files (i.e. it works, it's just not as comfortable as it could be). This bug reports a problem the Guess Tags from Filename *functionality* (i.e. doesn't work). They should be separate bugs. *** Bug 280288 has been marked as a duplicate of this bug. *** Git commit 0d78ff0561ce2717789f298d716b971b2c87a36c by Sergey Ivanov. Committed on 20/08/2011 at 19:09. Pushed by ivanov into branch 'master'. Fixed several bugs in TagGuesser. Now It can store presets (as OrganizeCollection do), correctly save settings on close and correctly guesses tags in case of using full file path. BUG: 280288 BUG: 264302 Particaly 264632 FIXED-IN: 2.4.4 M +5 -93 src/dialogs/OrganizeCollectionDialogBase.ui M +4 -31 src/dialogs/TagDialog.cpp M +3 -0 ChangeLog M +7 -2 shared/TagsFromFileNameGuesser.cpp M +12 -0 src/dialogs/FilenameLayoutDialog.h M +2 -1 src/dialogs/TagGuesser.cpp M +0 -8 src/dialogs/OrganizeCollectionDialog.h M +93 -5 src/dialogs/FilenameLayoutDialog.ui M +336 -231 src/dialogs/FilenameLayoutDialog.cpp M +2 -92 src/dialogs/OrganizeCollectionDialog.cpp http://commits.kde.org/amarok/0d78ff0561ce2717789f298d716b971b2c87a36c |