Summary: | dophin no embeded player in data panel for mp4 video | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Philippe ROUBACH <philippe.roubach> |
Component: | panels: information | Assignee: | Frank Reininghaus <frank78ac> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | adaptee, martin.sandsmark, myriam, nicofo, sitter, sladivadi |
Priority: | NOR | ||
Version: | 2.1 | ||
Target Milestone: | --- | ||
Platform: | Mandriva RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/d1808d56ec856162dd285ca9e3f8f067b8f474f3 | Version Fixed In: | 4.9.1 |
Attachments: |
mov.png
mp4.png mov_1.png |
Description
Philippe ROUBACH
2010-09-27 14:31:51 UTC
addendum : in the contextual menu there is an option to play the video with dragon player addendum : in the data panel there is a thumbnail of the video Phonon is not used for thumbnailing (which is bug of its own). Moving to kdemultimedia since supposedly ffmpegthumbs or mplayerthumbs is responsible. (In reply to comment #3) > Phonon is not used for thumbnailing (which is bug of its own). Moving to > kdemultimedia since supposedly ffmpegthumbs or mplayerthumbs is responsible. there is a misunderstanding. it is not a thumbnail pb there is a thumbnail for mp4 movie if you select a .mov then in the data panel (the right one) under the the thumbnail there is a player to view the movie see the attachment mov.png if you select a .mp4 then in the data panel (the right one) under the the thumbnail there is no player to view the movie see the attachment mp4.png Created attachment 72551 [details]
mov.png
Created attachment 72552 [details]
mp4.png
Created attachment 72553 [details]
mov_1.png
mov.png is a bad capture.ignore it use mov_1.png instead sorry :O const bool usePhonon = Phonon::BackendCapabilities::isMimeTypeAvailable(mimeType) && (mimeType != "image/png"); // TODO: workaround, as Phonon // thinks it supports PNG images Dolphin issue Please note my comments in bug 291438 and bug 303253#c13 The reason this "workaround" is needed is because Phonon *actually* supports PNG (i.e. if you were to load a PNG in either VLC or GStreamer you would actually get the PNG displayed). As I mentioned numerous times just about everywhere the mimetype API is just silly and should not be used. If you simply offer the playback for both audio/* and video/* you will get by a magnitude better results as both support Phonon backends basically support all the possible formats that there are. Thanks for the explanation, Harald! If I understand you correctly, the best approach would be to replace the lines you quoted above with const bool usePhonon = mimeType.startsWith("audio/") || mimeType.startsWith("video/")? Yep fixed in 2fb4419de053c43a0a70ffb21920db687fa87b6e Git commit d1808d56ec856162dd285ca9e3f8f067b8f474f3 by Jekyll Wu, on behalf of Martin Sandsmark. Committed on 09/08/2012 at 03:27. Pushed by jekyllwu into branch 'KDE/4.9'. Use a saner check for multimedia files in infopanel. Don't rely on the reported supported mimetypes from Phonon, Phonon supports more than just video and audio, but if it is video or audio there's a very good chance Phonon supports it. (If the mime type isn't in the list returned by Phonon there's still a good chance it supports it, because mime types are stupid.) FIXED-IN: 4.9.1 (cherry picked from commit 2fb4419de053c43a0a70ffb21920db687fa87b6e) M +1 -3 dolphin/src/panels/information/informationpanelcontent.cpp http://commits.kde.org/kde-baseapps/d1808d56ec856162dd285ca9e3f8f067b8f474f3 Thanks to everyone who helped to fix this bug! *** Bug 206312 has been marked as a duplicate of this bug. *** *** Bug 309607 has been marked as a duplicate of this bug. *** |