| Summary: | Window Behavior config dialog starts with the wrong page | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | András Manţia <amantia> |
| Component: | kdeui | Assignee: | Bastian Senst <bastianholst> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | abrouwers, bastianholst, cfeck, dantti12, diego.ml, jay, jorge.adriano, nbigaouette, sourtooth+ssbugs |
| Priority: | NOR | ||
| Version: | 4.5 | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.5.3 | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
|
Description
András Manţia
2010-09-01 08:05:16 UTC
To reproduce: "kcmshell4 clock style" (NB: "You will be asked to authenticate before saving" starts non-bold, when clicking on "Date & Time", it gets bold) *** Bug 249827 has been marked as a duplicate of this bug. *** *** Bug 252336 has been marked as a duplicate of this bug. *** *** Bug 253023 has been marked as a duplicate of this bug. *** This bug still exists in 4.5.2. Created attachment 52257 [details]
Screenshot
I'm hit with this issue on two machines running up to date Arch (kernel 2.6.35.7, Xorg 1.9, qt 4.7, xf86-video-intel 2.12) since 4.5.0. One laptop (GM965) and one netbook (GM945).
I'm attaching a screenshot, just in case.
*** Bug 253983 has been marked as a duplicate of this bug. *** Well, this seems to be a bug introduced in r1168413. Here the a connection to the signal currentChanged() was changed the the signal selectionChanged(). Reverting the patch fixes it for me. r1168413 fixes bug #163693 The bug mentioned in #163693 is not reproducable here. I'd have to investigate a little more to find a solution fixing both problems. Added some guys from bug #163693 Perhaps you can help. *** Bug 254022 has been marked as a duplicate of this bug. *** The bug was intoduced due to the change of connecting to selectionChanged() instead of currentChanged(). “kcmshell4 clock style” adds first the clock page and inserts the style page before it. QItemSelectionModel checks if the selection has been changed (by comparing the QModelIndexes), but nothing has been changed (still the first item is selected), so no selectionChanged() will be emitted (but currentChanged()). If I have items R,S,T, with S selected, and insert an item before R, then the list is now Q,R,S,T, but still S should be selected. Are you implying that now R would be selected, because it is still the second item? Maybe someone forgot the begin/endInsertRows() calls in the underlying model. (In reply to comment #12) > Maybe someone forgot the begin/endInsertRows() calls in the underlying model. That's exactly how it seems to me at the moment. I'm currently working on this. SVN commit 1185487 by bholst: Adding missing beginInsertRows() and endInsertRows() calls in KPageWidgetModel: beginInsertRows() has to be called before inserting rows and endInsertRows() has to be called after inserting rows in a subclass of QAbstractItemModel. CCBUG: 249706 M +31 -1 kpagewidgetmodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1185487 SVN commit 1185518 by bholst: Adding missing beginInsertRows() and endInsertRows() calls in KPageWidgetModel: beginInsertRows() has to be called before inserting rows and endInsertRows() has to be called after inserting rows in a subclass of QAbstractItemModel. CCBUG: 249706 Backport of r1185487 M +31 -1 kpagewidgetmodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1185518 |