| Summary: | Context View: Wrong applet size | ||
|---|---|---|---|
| Product: | [Plasma] plasma4 | Reporter: | Christian (Fuchs) <kde> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | normal | CC: | amarok-bugs-dist, lfranchi, martin.blumenstingl, mfraz74+kde, null, optiluca, rakuco, simon.esneault, vo.zaeb, wonko |
| Priority: | NOR | ||
| Version: | 4.5 and older | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Amarok in KDE 4.5 | ||
|
Description
Christian (Fuchs)
2010-07-21 19:04:26 UTC
Confirmed commit 2e6be3107e8eba174c25260ec4ca5c97b6635b63 Author: Leo Franchi <lfranchi@kde.org> Date: Wed Jul 21 21:34:34 2010 -0400 Kick context view into resizing after load. BUG: 245342 diff --git a/src/context/ContextDock.cpp b/src/context/ContextDock.cpp index 411b2f6..1cdeb10 100644 --- a/src/context/ContextDock.cpp +++ b/src/context/ContextDock.cpp @@ -74,6 +74,7 @@ ContextDock::createContextView( Plasma::Containment *containment ) connect( m_contextToolbarView, SIGNAL( hideAppletExplorer() ), m_contextView, SLOT( hideAppletExplorer() ) ); connect( m_contextToolbarView, SIGNAL( showAppletExplorer() ), m_contextView, SLOT( showAppletExplorer() ) ); m_contextView->showHome(); + m_contextView->resize( sizeHint() ); PERF_LOG( "ContexView created" ) } hmm, not completely fixed, damn. Created attachment 49729 [details]
Amarok in KDE 4.5
As you can see on the screen shot, in KDE 4.5 context view looks broken.
The last git commits solved this for me, could you all please check again? The bug that was showed on my screenshot is not fixed. But seems that this is a some different bug, and, probably, I should create a new bug report? Also, after the "mouseover" event of the Context view, Current track and Lyrics applets return to normal width, but Video clip applet not. That might well be a problem related to the Video applet in that case, see also bug 214156 (In reply to comment #7) I think it is not, because all applets on my screenshot are broken and because I am do not talking about video playback. Right, sorry for the confusion. Do your applets resize when you change the width of the Context View? Then this is the same bug, if not the bug is different. (In reply to comment #9) That's all right. Yes, they do, except of the Video applet — it doesn't. I think tis is particular to the video applet, then, please make a new report. I can confirm that the other applets are now sized correctly. But I can also confirm the issue with the video applet. However, I guess this particular report can be marked as fixed. If you feel so and want a separate report for the video applet, please close this one. I leave it as open in the meantime. Thanks for the fix. Kind regards Thank you for the feedback. It would be good to open a new report for the Video applet, as it's problem is not necessarily the same. Ouch, it's back with the latest git build :) Fixed in git as of aac7ab92d3831b00d94707fbcf86cbcebf1db051 Definitely :) (In reply to comment #15) Not for me. Yep, it is back here, too :( also not fixed for me (KDE 4.5.0 and Qt 4.6.3) Hi, can someone please mark this patch as "FIXED - UPSTREAM"? This was a bug in KDE 4.5's plasma. Here's a snipped from the conversation with notmart on irc: <notmart> one line patch in libplasma, backported to 4.5 as well The svn revision for this fix is 1168893. Oh and thanks notmart :) Regards, Martin Is this in time for KDE 4.5.1 or will it be in 4.5.2 only? See comment #21 looks like it didn't make it into 4.5.1 anymore :( *sigh*, that's what I suspected already :( *** Bug 249758 has been marked as a duplicate of this bug. *** I only started seeing this bug after upgrading Amarok from 2.3.2 beta to 2.3.2. This is with Kubuntu 10.04 and KDE 4.5.1. JFYI: this is a plasma bug, fixed in the upcoming KDE 4.5.2 How come I didn't have the problem with 2.3.2 beta then? Read what I said: this does not depend on Amarok, but on Plasma and the KDE version you use I read that, but what I was saying is that when I was using 2.3.2 beta I was also using KDE 4.5.1. When the upgrade from 2.3.2 beta to 2.3.2 came through no other packages were upgraded. Simply because we tried to work around this bug for KDE 4.5.1 users, it sadly doesn't work for everyone. No need to be picky about it, this will be definitfely solved once KDE 4.5.2 is out. @Myriam: I'm sorry to say there is absolutely no fix on the horizon in Plasma itself. The bug fix you're talking about was something different. Reopening, since it still happens with kde trunk. See http://i0.simplest-image-hosting.net/168bf183b2abe8bc9188aacc163dd507/plasma-desktopym2004.jpg *** Bug 252418 has been marked as a duplicate of this bug. *** Closing for lack of feedback. Please feel free to reopen this report if you can still reproduce this with KDE 4.8.3 or later. |
