| Summary: | Object-locked and object-unlocked are too similar | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Nikola Kovacs <nx.devnull> |
| Component: | Icons | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kainz.a, linux, nate |
| Priority: | NOR | ||
| Version: | 5.20.5 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/breeze-icons/commit/ba656561dea41c570bae1dca88e1247b8a96189a | Version Fixed In: | 5.81 |
| Sentry Crash Report: | |||
| Attachments: |
Inkscape's layer view
Inkscape's layer view with fallback icon Desaturated object-unlocked.png Good visual design example from Breeze in 2021 Bad visual design example from Breeze in 2021 |
||
Created attachment 49132 [details]
Inkscape's layer view with fallback icon
These are the default icons used when the icon theme doesn't supply them.
valid bug do you hapend to know if the fredesktop naming speck as a specific name icon for this? Bug 330947 might be a duplicate of this, caused by digikam. My proposal for an alternative icon is partial desaturation. A trivial example based on pinheiros icon is atached. I don't request copy rights for it. Created attachment 85084 [details]
Desaturated object-unlocked.png
Thank you for the bug report. As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists. If this bug is no longer persisting or relevant please change the status to resolved. Created attachment 136565 [details]
Good visual design example from Breeze in 2021
Created attachment 136566 [details]
Bad visual design example from Breeze in 2021
Thanks for digging out this old bug. The overarching visual design issue still exists in several icon sets, but good examples exist as attached. I've visually all icon sets installed with plasma 5.20.5 . Offenders exist in several of them, including 'High Contrast' (where it has more impact to the audience). Probably due to changing the default icon set, I can no longer find applicable icons in Oxygen. I've changed the affected 'product' accordingly. Thanks for forwarding to all the graphics designers working on all icon sets. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/92 (In reply to Bug Janitor Service from comment #10) > A possibly relevant merge request was started @ > https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/92 Thanks a lot for that nice solution. Thanks also to Justin for waking up that old bug. Git commit ba656561dea41c570bae1dca88e1247b8a96189a by Nate Graham. Committed on 10/03/2021 at 20:48. Pushed by ndavis into branch 'master'. Make lock icon filled status consistent Most lock icons were filled when locked and hollow when unlocked, but a few were not, in particular: - emblem-unlocked - folder-locked - system-lock-screen This is corrected, and now all locked icons follow the pattern. FIXED-IN: 5.81 M +9 -16 icons-dark/actions/32/system-lock-screen.svg M +6 -9 icons-dark/emblems/16/emblem-unlocked.svg M +6 -9 icons-dark/emblems/22/emblem-unlocked.svg M +5 -7 icons-dark/emblems/8/emblem-unlocked.svg M +11 -13 icons-dark/places/16/folder-locked.svg M +9 -13 icons-dark/places/22/folder-locked.svg M +20 -23 icons-dark/places/32/folder-locked.svg M +5 -5 icons-dark/places/48/folder-locked.svg M +20 -23 icons-dark/places/64/folder-locked.svg M +16 -14 icons-dark/places/96/folder-locked.svg M +9 -16 icons/actions/32/system-lock-screen.svg M +6 -9 icons/emblems/16/emblem-unlocked.svg M +6 -9 icons/emblems/22/emblem-unlocked.svg M +4 -6 icons/emblems/8/emblem-unlocked.svg M +11 -13 icons/places/16/folder-locked.svg M +9 -13 icons/places/22/folder-locked.svg M +20 -23 icons/places/32/folder-locked.svg M +5 -5 icons/places/48/folder-locked.svg M +20 -23 icons/places/64/folder-locked.svg M +16 -14 icons/places/96/folder-locked.svg https://invent.kde.org/frameworks/breeze-icons/commit/ba656561dea41c570bae1dca88e1247b8a96189a |
Created attachment 49131 [details] Inkscape's layer view Version: unspecified (using Devel) OS: Linux These two icons so similar that it is almost impossible to differentiate them at smaller sizes. For example, they are used by Inkscape to indicate whether a layer is locked or unlocked. See the attached screenshot - you have to look very closely to see the difference. Reproducible: Always