Summary: | Can't edit & save an existing equalizer preset | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Harley Laue <losinggeneration> |
Component: | Tools/Equalizer | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | illya.kovalevskyy, kfunk, ognyan_angelov, ralf-engels, zmogas |
Priority: | NOR | ||
Version: | 2.6-git | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/amarok/97c5144faf608b8fca0522cff4f9590fe09896bf | Version Fixed In: | 2.8 |
Description
Harley Laue
2010-06-16 03:04:07 UTC
I should have added equalizer to the title so it's more likely to be found if others search for reports on equalizer presets. Setup: Amarok 2.3.2 KDE 4.4.5 Test Result: Same Bug occurs here. Setting to confirmed, updated version. This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. It is indeed reproducible with 2.4.1. I can't seem to update the version myself though. Thank you for the feedback. Just investigated, not really fixable at the moment. As soon as the combo box is left, a indexChanged signal is emitted which causes a reload of the current item (intended, actually). The Equalizer would have to be redesigned, e.g. use a modal line edit for entering the to-be-saved preset name. Just FYI. This Bug also exists in version 2.5.0. That error on: ====== Kubuntu 12.10 Qt 4.8.3 Amarok 4.7 (beta) ====== Cannot edit or save an existing equalizer preset. I agree that I don't understand this preset stuff. Why does the preset always fall back to "manual"? Will have a look at the code. Git commit 97c5144faf608b8fca0522cff4f9590fe09896bf by Ralf Engels. Committed on 22/01/2013 at 14:40. Pushed by rengels into branch 'master'. Refactoring for Equalizer dialog Add comments Improve saving of pre-defined presets Fix Can't edit & save an existing equalizer preset Cleanup of the Equalizer stuff a bit, expecially the Equalizer Dialog Related: bug 274972 FIXED-IN: 2.8 M +0 -1 src/App.cpp M +168 -181 src/dialogs/EqualizerDialog.cpp M +38 -19 src/dialogs/EqualizerDialog.h M +17 -47 src/dialogs/EqualizerDialog.ui M +32 -27 src/equalizer/EqualizerPresets.cpp M +29 -12 src/equalizer/EqualizerPresets.h http://commits.kde.org/amarok/97c5144faf608b8fca0522cff4f9590fe09896bf |