Version: 2.4-GIT (using KDE 4.6.0)
The Equalizer API in Amarok needs polishing. It is not modular at all and clutters EngineController API. Also the EqualizerDialog frontend is not properly coded. We need a cleanup for this.
Report back if you need guidance with this.
Reproducible: Didn't try
Not a wish.
Added to Extra Mile.
Why is an API-related request an Extramile bug? IIRC Extramile is for user-visible bugs.
(In reply to comment #3)
> Why is an API-related request an Extramile bug? IIRC Extramile is for
> user-visible bugs.
You are right, removed.
API designing isn't a junior job, don't scare newcomers. ;)
Git commit 97c5144faf608b8fca0522cff4f9590fe09896bf by Ralf Engels.
Committed on 22/01/2013 at 14:40.
Pushed by rengels into branch 'master'.
Refactoring for Equalizer dialog
Improve saving of pre-defined presets
Fix Can't edit & save an existing equalizer preset
Cleanup of the Equalizer stuff a bit, expecially the Equalizer Dialog
Related: bug 241874
M +0 -1 src/App.cpp
M +168 -181 src/dialogs/EqualizerDialog.cpp
M +38 -19 src/dialogs/EqualizerDialog.h
M +17 -47 src/dialogs/EqualizerDialog.ui
M +32 -27 src/equalizer/EqualizerPresets.cpp
M +29 -12 src/equalizer/EqualizerPresets.h