Bug 220068

Summary:	dark theme: active item in menu is hardly different than others items
Product:	[Applications] digikam	Reporter:	Maciej Pilichowski <bluedzins>
Component:	Usability-Menus	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs.kde.j, caulier.gilles, lucianus.nistor, sylvainsjc, wooly1111
Priority:	NOR
Version:	1.2.0
Target Milestone:	---
Platform:	openSUSE
OS:	Unspecified
Latest Commit:	http://commits.kde.org/digikam/4837b2773846c7c32e947d3b1b8b706275731b95	Version Fixed In:	5.0.0
Sentry Crash Report:
Attachments:	digiKam screenshot with Dark theme and Oxgen theme

Description Maciej Pilichowski 2009-12-25 18:00:52 UTC

Version:            (using KDE 4.3.3)
Installed from:    SuSE RPMs

"Normal" theme -- you get navy (active menu item) on white (normal background color).
Dark theme -- you get very dark brown on dark brown. It is impossible to say which item is active really without long looking at the menu.

Comment 1 Flamand 2010-05-22 19:22:52 UTC

I have this bug on my computer too, with with digikam 1.2 on kubuntu 10.04.

I can't use "dark and "dark room" themes because text is in black on black backgroung. In the previous version, i didn't have that problem.

Comment 2 caulier.gilles 2010-05-31 10:58:52 UTC

*** Bug 229043 has been marked as a duplicate of this bug. ***

Comment 3 caulier.gilles 2010-05-31 14:54:04 UTC

*** Bug 240224 has been marked as a duplicate of this bug. ***

Comment 4 caulier.gilles 2010-05-31 15:16:32 UTC

Created attachment 47520 [details]
digiKam screenshot with Dark theme and Oxgen theme

It's not reproducible there. I use Oxygen color scheme from KDE control panel and Dark theme in digiKam

The problem can become of a special KDE color scheme used with Dark scheme in digiKam

Gilles Caulier

Comment 5 Jonas 2010-06-01 13:56:45 UTC

I think it is no bug of a special KDE color scheme, it is a bug of the color scheme system itself. I found no option to chance the color of the mentioned menu.

I tried to switch to the default color scheme in the system settings and changed everything with color black to an other color. But the mentioned menu stays with black text.

Comment 6 sylvainsjc 2010-08-28 12:34:15 UTC

rather annoying problem
Expecting a solution soon
regards

Comment 7 caulier.gilles 2011-04-07 14:11:00 UTC

Git commit e55f3d748f461f2f1ac956995d644de658200a4a by Gilles Caulier.
Committed on 07/04/2011 at 14:11.
Pushed by cgilles into branch 'master'.

port digiKam theme engine to KDE color Theme engine.
Now, there is no mix between digiKam color engine and KDE theme used in background.
Benefits : we can donload new color theme scheme from KDE control center and apply it to digiKam as well,
independently of the rest of KDE.

To end users : I don't tested under Gnome. Please give me a feedback...

BUGS: 257803
BUGS: 250265
BUGS: 220068
BUGS: 241116
BUGS: 252700
BUGS: 168669
CCBUGS: 265554

M  +0    -1    data/CMakeLists.txt     
D  +0    -74   data/themes/Blue     
D  +0    -15   data/themes/CMakeLists.txt     
D  +0    -75   data/themes/Clean     
D  +0    -75   data/themes/DLR     
D  +0    -74   data/themes/Dark     
D  +0    -78   data/themes/DarkRoom     
D  +0    -63   data/themes/Dessert     
D  +0    -75   data/themes/Digikasa     
D  +0    -75   data/themes/Dreary     
D  +0    -63   data/themes/Gray     
D  +0    -75   data/themes/Marine     
D  +0    -75   data/themes/OrangeCrush     
D  +0    -62   data/themes/Rose     
D  +0    -75   data/themes/Sandy     
M  +13   -40   digikam/main/digikamapp.cpp     
M  +1    -3    digikam/main/digikamapp.h     
M  +0    -3    digikam/main/digikamapp_p.h     
M  +1    -5    libs/themeengine/theme.cpp     
M  +1    -4    libs/themeengine/theme.h     
M  +198  -1187 libs/themeengine/themeengine.cpp     
M  +16   -15   libs/themeengine/themeengine.h     
M  +6    -5    showfoto/main/showfoto.cpp     
M  +1    -29   utilities/cameragui/main/cameraui.cpp     
M  +0    -3    utilities/cameragui/main/cameraui.h     
M  +0    -3    utilities/cameragui/main/cameraui_p.h     
M  +1    -43   utilities/imageeditor/editor/editorwindow.cpp     
M  +0    -6    utilities/imageeditor/editor/editorwindow.h     
M  +0    -12   utilities/imageeditor/editor/imagewindow.cpp     
M  +0    -2    utilities/imageeditor/editor/imagewindow.h     
M  +1    -32   utilities/lighttable/lighttablewindow.cpp     
M  +0    -3    utilities/lighttable/lighttablewindow.h     
M  +0    -3    utilities/lighttable/lighttablewindow_p.h     
M  +1    -32   utilities/queuemanager/main/queuemgrwindow.cpp     
M  +0    -3    utilities/queuemanager/main/queuemgrwindow.h     
M  +0    -3    utilities/queuemanager/main/queuemgrwindow_p.h     

http://commits.kde.org/digikam/e55f3d748f461f2f1ac956995d644de658200a4a

Comment 8 caulier.gilles 2016-05-30 18:57:13 UTC

Git commit 4837b2773846c7c32e947d3b1b8b706275731b95 by Gilles Caulier.
Committed on 30/05/2016 at 18:54.
Pushed by cgilles into branch 'master'.

Dispatch colors theme properly to widget style manager for main windows
Related: bug 172632, bug 241116, bug 146938, bug 265554, bug 240148, bug 252700, bug 168669, bug 179898
FIXED-IN: 5.0.0

M  +2    -1    libs/widgets/mainview/thememanager.cpp

http://commits.kde.org/digikam/4837b2773846c7c32e947d3b1b8b706275731b95