Bug 205157

Summary: two clicks on file to rename
Product: [Applications] dolphin Reporter: MisterE <edwin>
Component: generalAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Severity: wishlist CC: ach, alpeterson, andreas.krutzler, aspotashev, bugseforuns, ejbiow, emdeck, finex, fraan, funkybomber, markg85, nate
Priority: NOR    
Version: 16.12.2   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: debut-patch

Description MisterE 2009-08-26 00:08:15 UTC
Version:           1.3 (using 4.3.00 (KDE 4.3.0), Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.30-1-amd64

With Windows you can do two left mouse-button clicks and you can edit the file (node). 
With Dolphin i have to select the file, press right mouse button, select "rename", make the change and press "rename" again.
I find the Windows solution quicker and more intuitive.
Comment 1 FiNeX 2009-08-26 11:16:20 UTC
I could agree with the "quicker", but about the "more intuitive" I completely disagree. It is intuitive for you which are used to do this action in Windows, but how many Windows users knows that?

P.S: I don't want to criticize the request, absolutly! I've simply wrote my opinion about _one_ of your reasons.
Comment 2 MisterE 2009-08-26 12:01:53 UTC
i don't mind if the right-click-way is kept, the question if this "new" way bothers other users (when accidently getting in the edit mode).
I guess not, they wil select another file or pressing "esc". But i think much "windows power users" will miss this way.

But otherways, a option could be introduced in the settings screen to turn it on/off. It may be off by default.
Comment 3 FiNeX 2009-09-20 23:56:55 UTC
*** Bug 173135 has been marked as a duplicate of this bug. ***
Comment 4 Michał D. (Emdek) 2009-09-21 08:30:32 UTC
This is not something new, this feature was available in Konqueror in 3.5 (or maybe before, don't know) but was lost during porting...
Comment 5 Mark 2009-11-08 21:22:37 UTC
Proposal on how to do this for single click and double click.

= Single click =
possible method
When the user left clicks a file and holds it the mouse button pressed AND does not move the button then the inline rename mode is activated

possible method
When the user single clicks a file and keeps it pressed then presses the right mouse button (so, left press - right press -- both pressed) then the inline rename mode is activated. In other words. the user selects the file with the left mutton, holds it and right clicks to activate the inline rename. Then (once active) both buttons can be released and the user can type what he/she wants

= Double Click =
Same was as in windows. left click to select the file and another left click on a active file to activate the inline rename.

Just some ideas on how it could be possibly done. If someone could make a patch to test those ideas.. that would be awesome.
Comment 6 Ed Biow 2009-11-10 18:25:52 UTC
I have missed this feature since I started using Linux almost exclusively 5 years ago.  However I would love to know how to enable the double click file rename feature in konqueror 3.5, I still use it extensively (and love it) in Hardy and Lenny and I've looked on the net for a way to do this and never found anything. Hints, Emdek?
Comment 7 Michał D. (Emdek) 2009-11-10 18:35:00 UTC
(In reply to comment #6)
> Hints, Emdek?

Sorry, but I don't remember where that setting was placed, I'm using KDE4 for long time now and my distribution dropped support for KDE3 some time ago so I can't check it...

I don't know if this worked also with "single click to open file" (it is default mode in Debian/Ubuntu, right?), I was using it with "double click" mode only.
Comment 8 Achim Bohnet 2012-03-06 22:02:00 UTC
Just my two cents:
a) doing the rename inline and not in a dialog would be a really good thing IMHO.
b) If (SHIFT)-<TAB>then  would jump to (prev)-next file and allows inline rename of it 
  would be very handy (and worth a blog entry)

Independently: Thx a lot for your great dolpin work!

Comment 9 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:22:30 UTC
Resetting assignee to default as per bug #305719
Comment 10 funkybomber 2016-04-08 06:18:30 UTC
Hello, I'm currently using Linux Mint with KDE 4.14.2, and this bug still hasn't been resolved after all these years.

Is it safe to assume that this feature is not going to be implemented in KDE 4 ?
Are there any plans for it to be implemented in KDE 5 ? Should we look forward to it?

I think that a lot of people transitioning to Linux from a Windows environment find the lack of this feature as a handicap. This functionality really IS intuitive, at least for power users.
One click to select the item (file/folder), second click (on the text) to rename it.

I know that the default answer here is "press F2 to rename", but it's just not the same. I spend one second to find and press F2, while I can do a second click in 200ms and start renaming.
( In Windows I always set my double click speed to a very low value, just to be able to enter rename mode faster! )

Don't take just my word for it. Why do you think that this issue comes up again time after time?
Here's another request for this feature (in Nautilus - but the concept is the same), dating back to 2006 !  

People will keep asking for this in 10 years time if it's not done! :)  And for a good reason!
Please note I'm not suggesting that this should be the default behavior, just an extra option "Click selected to edit" to go along with the single/double click options. 

Kind regards!
Comment 11 andreas.krutzler 2016-04-10 12:53:26 UTC
Created attachment 98318 [details]

When I was switch from windows to linux about 10 years ago, this was also one big feature that I have missed. I got more or less used to it  but I still think its very usefull so i wrote an patch to add this feature.
By default its turned off. To turn it on go to Control->Configure dolphin->General. There should be an switch called "Fast renaming" (maybe we should change that).
The behavior is quite the same as in windows file manager.
Comment 12 funkybomber 2016-04-12 05:03:09 UTC
Do I have to apply the patch manually or should I wait for it to become available through the regular updates of my distribution? (that might take a while I suppose)

If it's the former, then could you please describe the proper steps to apply the patch?

Either way, thanks for your effort!
Comment 13 funkybomber 2017-03-14 12:29:42 UTC
Follow up in the review board:

Hopefully this will trigger a discussion on what needs to be done for this bug. The more people who give feedback on this issue, the better.

I have made my opinion known all too many times by now.
Comment 14 Nate Graham 2017-08-18 15:07:09 UTC
I hate to keep jerking you guys around, but can you re-post the patch to Phabricator? That's the infrastructure that KDE has moved to.


Please add "KDE Applications" and "Dolphin" as review groups, to make sure it gets seen.
Comment 15 Nate Graham 2017-08-18 18:05:58 UTC
*** Bug 246645 has been marked as a duplicate of this bug. ***
Comment 16 Nate Graham 2017-10-27 13:06:57 UTC
Git commit 5454283008f26d377a6403861a3cdd7992dbbd38 by Nathaniel Graham, on behalf of Andreas Krutzler.
Committed on 27/10/2017 at 13:06.
Pushed by ngraham into branch 'master'.

Two clicks on file/folder to rename

Make renaming of files/folders faster by clicking a second time on the items text to start renaming.

Test Plan:
This feature works as follows:

1. select an item by single-click, or one is already selected
2. wait the "double-click-interval"
3. click on the items text
4. none of the cancellations (see below) happens within the double-click-interval
5. inline-renaming starts

* open any file/folder
* select different item(s)
* start dragging items
* Dolphin loses focus

This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled.

Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx

Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx

Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham

Differential Revision: https://phabricator.kde.org/D7647

M  +4    -0    src/kitemviews/kitemlistcontroller.cpp
M  +2    -0    src/kitemviews/kitemlistcontroller.h
M  +13   -0    src/kitemviews/kitemlistview.cpp
M  +1    -0    src/kitemviews/kitemlistview.h
M  +47   -6    src/views/dolphinview.cpp
M  +8    -0    src/views/dolphinview.h

Comment 17 Nate Graham 2017-10-27 22:05:14 UTC
*** Bug 386268 has been marked as a duplicate of this bug. ***
Comment 18 Achim Bohnet 2018-01-19 09:36:06 UTC
I've found it works also with single-click. At least with 17.12.1

* Click (without release) on the name of a already selected file/folder
* After the (double-click?)-timeout without releasing the mouse button the filename can be edited inline.

Thx a lot for implementing it!