Summary: | Amarok launches Amarok.Lyrics.fetchLyrics signal but it is not necessary | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Ignacio Serantes <kde> |
Component: | Tools/Script Manager | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | lfranchi, martin.blumenstingl, peterzhoulei |
Priority: | NOR | ||
Version: | 2.0.1 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Ignacio Serantes
2009-03-03 10:24:00 UTC
Any news on that? Bug is still unconfirmed and 2.0.1 is already quite old... Does this still happen with Amarok 2.1? Yes but now, in 2.0.96, is worst because Amarok always is calling for lyrics. I'm have no problem because I write a lyrics script with a cache but is stupid call for lyrics if lyrics are in database. The lyrics systems must be simple: if thereIsLyrics { displayLyrics(); } else { getLyrics(); } and this must be called one time on song change. No more and no less with the exception of a button to manually call get lyrics again, a refresh button. I really don't understand why a simple stuff is so complicated in Amarok 2. Why hasn't anyone subscribed Peter yet? probably b/c most of the lyrics stuff (even scripting) is mine. i'll take a look when i have a chance. I'll take a look at this. :) I am concern about breaking the API before we having a mature versioning system. This is maybe not the case of breaking the API though. Any news on this? might be a duplicate of #191236 *** Bug 191236 has been marked as a duplicate of this bug. *** http://gitorious.org/amarok/amarok/commit/b0a06ac98546cbe0b52e22137333ab76b7433918 fixes bug 191236. I'm not sure it fixes this bug, though. Ignacio, does this still happen with current Amarok 2.2? No, I test with current git version and seems to be solved because my lyric is not called if lyrics was stored in db. |