Bug 172632

Summary:	Album item tooltip doesn't use colors of themes properly
Product:	[Applications] digikam	Reporter:	Antonio E. <aironmail>
Component:	Usability-Themes	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	0.10.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:	http://commits.kde.org/digikam/4837b2773846c7c32e947d3b1b8b706275731b95	Version Fixed In:	5.0.0
Sentry Crash Report:

Description Antonio E. 2008-10-12 03:40:28 UTC

Version:            (using Devel)
Installed from:    Compiled sources

I've noticed something minour but well, good to report.

It's about the item tooltips at the albums view.

I'm using the "default" theme.

Now I go to Settings -> Configure digikam -> Tool Tip

I enable the "Show album item tooltips.

I press OK and close the configuration window.

Now I go to an image and put the mouse pointer on it, I can see a tooltip, with a gray background, black text and some cyan text background. Perfectly readable.

Now I go to Themes, and I change it to DLR.

I place the mouse pointer again over an image, the tooltip opens, the background is now black, as the them, but the text is kept as black so impossible to read, and the text background of the titles that were cyan on the other them, now are again cyan.

So it seems that when the theme is changed, the tooltip is ignoring the new text color and the text background for the titles. It's like if the tooltips were using fixed colors for the text and the title background instead of taking them from the theme configuration.

I have tried with different themes and it always happens the same, but obviously worse on themes with a dark background.

Now a little extra thing, on the configuration panel, for tooltip, on the left panel, that word is written as "Tool Tip" and inside the right panel as "tooltip". So one with a blank space dividing it on two words and the other as a single word. They should be written on the same way I think.

Comment 1 Antonio E. 2008-10-12 03:41:51 UTC

Just a note to clarify that this happens on digikam 0.10 (beta5) svn.

Comment 2 Mikolaj Machowski 2008-12-06 22:00:34 UTC

Confirming for beta7svn. Maybe just scrap theme for tooltip?

Comment 3 caulier.gilles 2008-12-07 11:37:15 UTC

SVN commit 893707 by cgilles:

digiKam from trunk (KDE4) : adapt icon view item tooltip color to color scheme.
CCBUGS: 172632


 M  +13 -9     albumfiletip.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=893707

Comment 4 caulier.gilles 2008-12-07 20:29:17 UTC

Mik,

The problem isn't not fully fixed. look like the tooltip contents from thumbbar is not fine.

I currently working to factorize code between thumbbar and inconview tooltip

Gilles

Comment 5 caulier.gilles 2008-12-09 16:45:28 UTC

SVN commit 894900 by cgilles:

digiKam from trunk (KDE4) : thumbbar improvements : tooltip is now based on albumfiletips implementation instead QToolTip
We have a better control of rendering of tooltip and it become homogenous with album icon view tool tip.
Now thumbbar tool tip support color scheme themes and is suitable with all schemes.

Still TODO : factoring albumfiletip.cpp and thumbbartooltip.cpp and imagepreviewbar.cpp when it's possible

BUG:172632


 M  +1 -0      CMakeLists.txt  
 M  +8 -5      digikam/imagepreviewbar.cpp  
 M  +3 -3      digikam/imagepreviewbar.h  
 M  +123 -293  libs/widgets/common/thumbbar.cpp  
 M  +6 -75     libs/widgets/common/thumbbar.h  
 AM            libs/widgets/common/thumbbartooltip.cpp   [License: GPL (v2+)]
 AM            libs/widgets/common/thumbbartooltip.h   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=894900

Comment 6 caulier.gilles 2016-05-30 18:57:13 UTC

Git commit 4837b2773846c7c32e947d3b1b8b706275731b95 by Gilles Caulier.
Committed on 30/05/2016 at 18:54.
Pushed by cgilles into branch 'master'.

Dispatch colors theme properly to widget style manager for main windows
Related: bug 241116, bug 146938, bug 265554, bug 240148, bug 252700, bug 168669, bug 179898, bug 220068
FIXED-IN: 5.0.0

M  +2    -1    libs/widgets/mainview/thememanager.cpp

http://commits.kde.org/digikam/4837b2773846c7c32e947d3b1b8b706275731b95