| Summary: | JJ: Amarok 2 can't playback .asx playlist | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | illogic-al <illogical1> |
| Component: | Playlists/Saved Playlists | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bart.cerneels, dmeltzer.devel, halo.jones, louisfinan, matej, nforce25, olivier.delaune, t.gornak, timo0002, usrrgt |
| Priority: | NOR | ||
| Version: | 2.4-GIT | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | macOS | ||
| Latest Commit: | http://commits.kde.org/amarok/e1eddb4a00b0d5bece5b9ddddeb59e95b460c762 | Version Fixed In: | 2.8 |
| Sentry Crash Report: | |||
| Attachments: | mediaplayer | ||
|
Description
illogic-al
2008-09-01 18:23:08 UTC
Tell me what I need to do to debug. Already tried downloading the file to disk and playing back in the phonon test app, which works. As far as I remember Amarok has its own ASX playlist reader. I suppose it might be broken. http://www.thepath.fm/cyberradio/media/cdrlive.asx test playlist Problem exists also on Mandriva Linux with Amarok 2.0.1.1. I cannot read asx webradio. We don't seem to have an asf playlist class at all any more... I know it existed at some point in 2.0 development, I have a feeling it got itself deleted in one of the zillion playlist managing code rewrites that we have gone through. Any news on this? Nope, we don't have ASF/ASX playlist support ATM. It requires a port of the 1.4 code to a new AsxPlaylist class. Patches are welcome. In Amarok 2.2 asx playlists worked just fine. In 2.3 it's broken, I can't add asx streams to the playlist. Is it because asx is evil? (In reply to comment #8) > In Amarok 2.2 asx playlists worked just fine. In 2.3 it's broken, I can't add > asx streams to the playlist. Is it because asx is evil? No, this looks more like a regression. *** This bug has been marked as a duplicate of bug 212445 *** Oops, wrong duplicate, sorry, I just can't put the finger on the other one I had today, sorry for the noise The problem persist at Amarok 2.3.1. Same problem, Amarok 2.3.1, KDE 4.5 and Linux. Created attachment 53020 [details]
mediaplayer
test pacth
Louis, please submit the patch to http://git.reviewboard.kde.org (you need to subscribe to http://identity.kde.org before that). What about Amarok 2.4? Louis, any news about that patch? (In reply to comment #13) > Created an attachment (id=53020) [details] > mediaplayer > > test pacth This is not a patch but an ASX file. Just had it open with VLC while expecting a diff. Patches adding ASX support are still welcome. Making this a Junior Job. Difficulty: medium, C++ code skills required. The same for Amarok 2.4, it can't play ASX files. More than two years later the bug still here, and with "new" status? Amarok, rediscover music with its exciting features: Now you can't play audio! NEW means it is confirmed, else it would be UNCONFIRMED. It also is marked as a Junior Job, so any helpers with Qt/C++ skills are welcome. Tatjana Gornak is working on this, starting with a cleanup-existing-playlistfiles patch in https://git.reviewboard.kde.org/r/107473/ Git commit c91a2017116789ecb5c63c7e850cb69cfeb6b6f1 by Matěj Laitl, on behalf of Tatjana Gornak. Committed on 05/04/2013 at 02:41. Pushed by laitl into branch 'master'. Asx playlist implementation FEATURES: * Added support for .asx playlists; patch by Tatjana Gornak FIXED-IN: 2.8 REVIEW: 109758 DIGEST: Amarok can now read & save .asx playlists M +1 -0 ChangeLog M +1 -0 src/CMakeLists.txt M +2 -0 src/MainWindow.cpp M +2 -0 src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp M +7 -0 src/core-impl/playlists/types/file/PlaylistFileSupport.cpp A +191 -0 src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp [License: GPL (v2+)] A +48 -0 src/core-impl/playlists/types/file/asx/ASXPlaylist.h [License: GPL (v2+)] M +1 -1 src/core/playlists/PlaylistFormat.cpp M +5 -1 src/playlistmanager/file/PlaylistFileProvider.cpp M +6 -0 tests/core-impl/playlists/types/file/CMakeLists.txt A +159 -0 tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp [License: GPL (v2+)] A +51 -0 tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h [License: GPL (v2+)] http://commits.kde.org/amarok/c91a2017116789ecb5c63c7e850cb69cfeb6b6f1 (In reply to comment #22) > Git commit c91a2017116789ecb5c63c7e850cb69cfeb6b6f1 by Matěj Laitl, on > behalf of Tatjana Gornak. > Committed on 05/04/2013 at 02:41. > Pushed by laitl into branch 'master'. No, not yet, this was pushed by error. The commit hooks fired, but the commits haven't reached Amarok master. Git commit e1eddb4a00b0d5bece5b9ddddeb59e95b460c762 by Matěj Laitl, on behalf of Tatjana Gornak. Committed on 05/04/2013 at 02:41. Pushed by laitl into branch 'master'. Asx playlist implementation FEATURES: * Added support for .asx playlists; patch by Tatjana Gornak FIXED-IN: 2.8 REVIEW: 109758 DIGEST: Amarok can now read & save .asx playlists M +1 -0 ChangeLog M +1 -0 src/CMakeLists.txt M +2 -0 src/MainWindow.cpp M +2 -0 src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp M +9 -1 src/core-impl/playlists/types/file/PlaylistFile.cpp M +7 -0 src/core-impl/playlists/types/file/PlaylistFileSupport.cpp A +192 -0 src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp [License: GPL (v2+)] A +47 -0 src/core-impl/playlists/types/file/asx/ASXPlaylist.h [License: GPL (v2+)] M +1 -1 src/core/playlists/PlaylistFormat.cpp M +5 -1 src/playlistmanager/file/PlaylistFileProvider.cpp M +6 -0 tests/core-impl/playlists/types/file/CMakeLists.txt A +159 -0 tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp [License: GPL (v2+)] A +51 -0 tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h [License: GPL (v2+)] http://commits.kde.org/amarok/e1eddb4a00b0d5bece5b9ddddeb59e95b460c762 *** Bug 283225 has been marked as a duplicate of this bug. *** |