Summary: | put back animated logo among toolbar widgets | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Maciej Pilichowski <bluedzins> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | CONFIRMED --- | ||
Severity: | wishlist | CC: | bugzilla, cfeck, finex, jjm |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Menu bars |
Description
Maciej Pilichowski
2008-06-08 12:11:21 UTC
*** Bug 164745 has been marked as a duplicate of this bug. *** Created attachment 28271 [details]
Menu bars
The screenshot shows the excess space in the Konqueror menubar. Firefox is on top, Konqueror below.
SVN commit 953953 by cfeck: Fix menu bar being too tall because of the animated logo The previous fix for the bug did not work, because Qt's menu bar does not respect the fixedSize() attribute of the button, but simply looks at sizeHint(). Also added an event filter to catch style and font changes. There is one issue: changing the font size resizes the button, but the icons are not reloaded. It causes KAnimatedButton to crash when enabling that code. Reviewed by dfaure CCBUG: 166593 CCBUG: 163519 CCBUG: 180856 CCBUG: 181642 CCBUG: 182124 M +1 -0 CMakeLists.txt A konqanimatedlogo.cpp [License: GPL (v2+)] A konqanimatedlogo_p.h [License: GPL (v2+)] M +3 -52 konqmainwindow.cpp M +2 -6 konqmainwindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=953953 @Christoph: hi! what about the one issue left open on your commit comment??? FiNeX, this bug got CCed in r953953 because it fixed the "too high menu bar", but the actual request for the throbber moved back to toolbars is still open. There is chance for that to happen in 4.6 for the global D-Bus based menu bar. As for the follow-up commit to address the mentioned crash, see (the actual) bug 166593. In Kubuntu's KDE 4.5.x version it is possible to have the throbber in the toolbar (addressbar). Finally it can be adjusted in size to the user's needs again, great. I hope this isn't only a Kubuntu hack. Alas in Kubuntu's Konqueror it is not possible to place the throbber at the right side of the search box. I hope when this enters KDE it will be possible to place the throbber as the most right element in the toolbar without the need to disable the search box. |