Bug 163306

Summary:	No visible button to empty wastebin
Product:	[Applications] dolphin	Reporter:	Frederik Himpe <fhimpe>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	adaptee, anikethgireesh, bugseforuns, codestruct, igaldino, infroma, kde, nate, usrrgt, xavier
Priority:	NOR	Keywords:	usability
Version:	16.12.2
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://commits.kde.org/dolphin/eb68fae15cdbf15e894d1a9d555c88d306261cc2	Version Fixed In:
Sentry Crash Report:

Description Frederik Himpe 2008-06-05 21:52:41 UTC

Version:           1.0.99 (using Devel)
Installed from:    Compiled sources

When you open the wastebin in Dolphin, there is no visible item which permits you to empty it. There should be at least a link or button "Empty wastebin" in the sidebar and an entry in the menus.

Comment 1 Peter Penz 2008-06-06 07:47:57 UTC

Thanks for your input! Could you please explain a little bit more detailed what kind of "visible item" you want and where? E. g. do you want to have an entry in the toolbar etc. Currently Dolphin offers an "Empty Trash" item in the Places Panel (context menu) or when pressing the context menu inside the trash folder.

Comment 2 Frederik Himpe 2008-06-06 09:08:27 UTC

I had not noticed the item in the context menu. I expected a link or button in Dolphin's sidebar. Or a Firefox/Nautilus like top bar could be another possibility: http://philbull.googlepages.com/Screenshot-DeletedItems-FileBrowser.png

Comment 3 Peter Penz 2008-06-06 10:52:31 UTC

Ah, I understand. Thanks for the update! I've set the state to NEW, I'll have to think about this...

Comment 4 Frank Reininghaus 2009-05-27 23:51:27 UTC

*** Bug 192171 has been marked as a duplicate of this bug. ***

Comment 5 Jekyll Wu 2012-01-05 08:35:56 UTC

Should this report be merged with bug 187226, or vice versa?

Comment 6 Peter Penz 2012-01-05 09:26:40 UTC

*** Bug 187226 has been marked as a duplicate of this bug. ***

Comment 7 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:19:56 UTC

Resetting assignee to default as per bug #305719

Comment 8 Isaque Galdino 2013-12-11 18:31:09 UTC

I would like to see this implemented in KDE as well.
I'm running KDE 4.11.3 (openSuse 13.1).
Thanks.

Comment 9 Elvis Angelaccio 2016-12-10 13:07:49 UTC

*** Bug 216395 has been marked as a duplicate of this bug. ***

Comment 10 Aniketh 2016-12-22 11:32:54 UTC

Is this bug fixed already? If not, I would like to work on it

Comment 11 Gregor Mi 2016-12-22 11:37:20 UTC

@Aniketh: The bug is still open. You are welcome to work on it.

Comment 12 Nate Graham 2017-08-18 15:14:38 UTC

@Aniketh: please feel free. When you have a patch, post it to http://phabricator.kde.org/ and add "KDE Applications" and "Dolphin" as review groups

Comment 13 Roman Inflianskas 2018-02-24 19:24:16 UTC

See https://phabricator.kde.org/D10804

Comment 14 Roman Inflianskas 2018-03-18 10:46:24 UTC

Git commit eb68fae15cdbf15e894d1a9d555c88d306261cc2 by Roman Inflianskas.
Committed on 18/03/2018 at 10:46.
Pushed by romaninflianskas into branch 'master'.

Show "Empty Trash" button inside trash directory

Summary:
Show "Empty Trash" button inside trash directory.

Test Plan: {F5734949}

Reviewers: ngraham, rkflx, markg, elvisangelaccio

Reviewed By: ngraham, markg, elvisangelaccio

Subscribers: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10804

M  +23   -2    src/dolphinviewcontainer.cpp
M  +3    -0    src/dolphinviewcontainer.h

https://commits.kde.org/dolphin/eb68fae15cdbf15e894d1a9d555c88d306261cc2