Bug 153376

> This is not in kde 3.96.2 anymore, bug or feature? 

Neither really.  This a request for enhancement, marking as a wishlist item.  

*** Bug 153248 has been marked as a duplicate of this bug. ***

*** Bug 161083 has been marked as a duplicate of this bug. ***

*** Bug 163972 has been marked as a duplicate of this bug. ***

*** Bug 164100 has been marked as a duplicate of this bug. ***

Will this ever be implemented?
Because I think it is a great idea

I am missing this menu as well. Please implement it in the new Konsole.

I also expect and miss this menu. Would be possible to implement it please. TIA.

To all people which would like this feature, please vote for it :-)

*** Bug 185108 has been marked as a duplicate of this bug. ***

*** Bug 186120 has been marked as a duplicate of this bug. ***

*** Bug 194431 has been marked as a duplicate of this bug. ***

*** Bug 199477 has been marked as a duplicate of this bug. ***

But it was there! Why it disappeared???

I voted for this bug as well. I currently prefer Konsole 3.5.x to the 4.x series because it has this feature. 

This has been classified as a "wishlist" item, but I think many of us see it as a regression-- a useful feature is now absent. The 3 options I used frequently were:  Monitor for Silence, Monitor for Activity and Rename Tab.  Sure, there are other ways to do this, but the ability to right-click on the tab was convenient and familiar.

I agree, there is a difference with a wish for a new feature , compared to something that was always there and is now missing. The renaming feature all and just the fact you were on the tab you want to do these things to. So your not accidentally changing the wrong one too

I do agree with the last 2 comments. From my point of view it was really easiest to rightclick on tabs to get some features like rename or monitor.

Any chance we could see this re-implemented in konsole 4.x ?

I agree that this feature should be implemented as well. It's a regression from earlier konsoles.

yes it got my votes. This request is more than 2 years old! all what is needed is a context menu which calls the same actions than in the normal menu, doesn't sound like a high effort. Does that mean entering wishes, comments, votes is just a waste of time?

yeah another thing thats MISSING is not a darn wish. So it shouldn't be on the wish list but delt with as a regression/bug period. So many great feature that are gone. :(

> Does that mean entering wishes, comments, votes is just a waste of time?

I think the next step is either for one of the commenters to volunteer to address the issue, or to track down a specific Konsole contributor, and ask them nicely about the possibility. You can review the "Changes" file or the source code commit logs to find out who has been contributing to Konsole recently. You might also ask politely on the developer mailing list.

No idea how to look that up. I would do it if I knew how. Though, what is the point of having a bugzilla if one has to beg via e-mail? Can someone post how to exactly look up these possible contributors?

> Though, what is the point of having a bugzilla if one has to beg via e-mail?

Bugzilla is indeed the right place to make feature requests.  reviewboard.kde.org is the right place to submit patches to fix bugs or add features.

> Robert Knight <robertknight@gmail.com> changed:

Robert,

Thanks for the clarification. 

Are you the same person as the "knight" user that's seen as a recent
Konsole committer here?

 http://websvn.kde.org/trunk/KDE/kdebase/apps/konsole/src/

If you are a Konsole committer, your feedback on this change request
would be appreciated. 

   Mark

> Are you the same person as the "knight" user that's
> seen as a recent Konsole committer here?

Yes.  Kurt Hindenburg and myself have been the most active developers of Konsole over the past few years, although I'm not doing a lot of work on it at the moment - though I do try to review any patches that get posted.

I have no objections to adding a right-click menu to the tabs.  I'm not able to promise that I will do it myself soon though, though I will try to find the time to review a patch if one is produced.

Created attachment 39694 [details]
Preliminary Patch to Add a Context Menu

This is a preliminary patch against the svn trunk that adds a context menu with two items - "Detach Session" and "Close Session". It is made against:

svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/apps/konsole

Regards,

-- Shlomi Fish

Created attachment 39695 [details]
A Newer Patch that also adds "Rename Session".

This is a newer patch that also adds rename session.

Hello,

Please post this patch on reviewboard.kde.org.

Some initial comments:

* ViewContainer::_contextMenuTabIndex needs to be initialized in the ViewContainer constructor
* kDebug() should be used if you need debugging information (in ViewManager::detachView())
* I think you can leave out the dynamic_cast in TabbedViewContainer::contextMenuTabDetach()
* The temporary memory leak from the QMenu which is created but not later destroyed needs to be fixed as per the TODO comment
* I suggest renaming the TabbedViewContainer::contextMenuTabRename() method to TabbedViewContainer::contextMenuRenameTab() (and likewise for the other context menu methods)
* When specifying types in SLOT() arguments you can leave out the 'const' and '&' parts of 'const T&'.  eg.  'SLOT(contextMenu(int, const QPoint &))' can be more compactly written as 'SLOT(contextMenu(int,QPoint))'
* The captions of the context menu items need to match those in the main menus.  eg. 'Rename Tab' instead of 'Rename Session'.  For consistency I would suggest changing the caption of the detach action to 'Detach Tab' in both the main menu and in the context menu.
* Re these lines:               

TabbedViewContainer * tabbedContainer;
container = tabbedContainer = 
 new TabbedViewContainer(position,_viewSplitter);

The 'tabbedContainer' variable is unnecessary since QObject::connect() uses duck-typing.  You can pass it a pointer of type ViewContainer (the 'container' variable) and still connect a signal or slot which is specific to a sub-class of ViewContainer.

Created attachment 39718 [details]
Patch that corrects the issues.

This is a patch in response to Robert Knight's comments, which fixes all the issues he pointed to. It was also posted on reviewboard

Has there been any update on this since it was submitted for review 2 months ago? 

I'm hoping the updates still have time to make there way into the Ubuntu/Kubuntu release coming out in April.

I'm afraid it is too late for Lucid.  The KDE packagers will only be accepting fixes for critical bugs now.

Does anyone know when this regression is fixed? The discussed fix should be in by now, shouldnt it? KDE 4.4.2 still has the same issue. Thanks.

(In reply to comment #32)
> Does anyone know when this regression is fixed? The discussed fix should be in
> by now, shouldnt it? KDE 4.4.2 still has the same issue. Thanks.

I second that. Please review the patch. I didn't include the "monitor session" / "demonitor session" menu entries in the context-menu due to laziness, but it's still much better than nothing. So please look into the patch and hopefully apply it. I am willing to give any further assistance as necessary, but believe the patch is pretty solid.

SVN commit 1115877 by hindenburg:

Implement 'Rename Tab...' and 'Close Tab' in tab context menu.
Original patch by Shlomi Fish.  I did some hacking on it and removed 'Detach Tab' option for this commit.

CCBUG: 153376


 M  +40 -2     ViewContainer.cpp  
 M  +6 -1      ViewContainer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1115877

Hi!

Thanks for commiting the patch. I hope we'll see it in KDE-4.5.x.

(In reply to comment #34)
> SVN commit 1115877 by hindenburg:
> 
> Implement 'Rename Tab...' and 'Close Tab' in tab context menu.
> Original patch by Shlomi Fish.  I did some hacking on it and removed 'Detach
> Tab' option for this commit.

May I ask why did you remove the "Detach Tab" option? Are you planning on adding it later? 

Regards,

-- Shlomi Fish



> 
> CCBUG: 153376
> 
> 
>  M  +40 -2     ViewContainer.cpp  
>  M  +6 -1      ViewContainer.h  
> 
> 
> WebSVN link: http://websvn.kde.org/?view=rev&revision=1115877

#35 - It will be in KDE 4.5;  the code for 'Detach Tab' was a bit more complex then the above.  I just wanted to separate them to make it easier for me.  It should be committed for 4.5 also.

(In reply to comment #36)
> #35 - It will be in KDE 4.5;  the code for 'Detach Tab' was a bit more complex
> then the above.  I just wanted to separate them to make it easier for me.  It
> should be committed for 4.5 also.

OK, thanks for the reply.

> I second that. Please review the patch. I didn't include the "monitor session"
> / "demonitor session" menu entries in the context-menu

I hope these can re-appear over time. I use them regularly. 

   Mark

(In reply to comment #38)
> > I second that. Please review the patch. I didn't include the "monitor session"
> > / "demonitor session" menu entries in the context-menu
> 
> I hope these can re-appear over time. I use them regularly. 
> 

Sure, I guess I can try to add them, at least after the detach tab code was integrated. I didn't bother adding them at first because they appeared hard-to-implement and because I never used them myself. 

Regards,

-- Shlomi Fish
>    Mark

The only issue I see with the detach menu is that you can still detach a tab even it is the only one.

It still works but is kinda awkward.

If you want other menu items please create separate wish lists.

SVN commit 1118851 by hindenburg:

Add 'Detach Tab' to the tab context menu.

Original patch by Shlomi Fish.  I did some hacking on it.

BUG: 153376


 M  +9 -0      ViewContainer.cpp  
 M  +5 -0      ViewContainer.h  
 M  +24 -7     ViewManager.cpp  
 M  +2 -0      ViewManager.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1118851

Hi, I don't think that this is resolved. In KDE 4.5.2 I still cannot use the context menu to create a new tab. This is still a regression to KDE 3.

(In reply to comment #42)
> Hi, I don't think that this is resolved. In KDE 4.5.2 I still cannot use the
> context menu to create a new tab. This is still a regression to KDE 3.

In this bug, we discussed the context menu of an individual tab - not of the unoccupied space in the tab bar. You can still create a new tab by pressing the "new tab" button or double clicking the tab bar. If you still miss that context menu, then file a new bug. (And CC me on it.)