| Summary: | [PATCH] "Unable to complete LIST" operation with invalid messages on server | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | John Birch <jbb> |
| Component: | pop3 | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cvevans, decibelshelp, ilovekde, jwork123nl, kim, mcmanus, rdieter, sac62, sysadmin |
| Priority: | NOR | ||
| Version: | 1.9.1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | patch for comment 15 | ||
|
Description
John Birch
2006-05-20 05:34:38 UTC
*** Bug 144273 has been marked as a duplicate of this bug. *** *** Bug 79569 has been marked as a duplicate of this bug. *** *** Bug 148225 has been marked as a duplicate of this bug. *** *** Bug 148368 has been marked as a duplicate of this bug. *** I have the same bug on 1.9.7. It's very anoying as I always have to delete the message without uidl first, kill the pop3 task and restart kmail before geetting my email!! I have the same bug on 1.9.7. It's very anoying as I always have to delete the message without uidl first, kill the pop3 task and restart kmail before geetting my email!! Same issue here. I had to setup Thunderbird until this get's figured out. Same issue here for the last 6 months. Switching to Thunderbird. I should mention my environment: kde3.5.8 on Kubuntu 7.10 (Gutsy Gibbon) Package kdepim-3.5.7enterprise20070926 Rebuilding from source now; will report on success or failure Rebuilt packages on Kubuntu 7.10. Results so far excellent. Thunderbird conversion averted, at least for now. Here are the steps: Using: http://www.debian-administration.org/articles/20 apt-get source kmail apt-get build-dep kmail Then I edited kdepim-3.5.7enterprise20070926/kmail/popaccount.cpp as illustrated as above, removing debug output statements: 964 else { 965 if( stage == List ){ 966 stage = Idle; 967 if (job) job->kill(); 968 job = 0; 969 mSlave = 0; 970 KMessageBox::error(0, i18n( "Unable to complete LIST operation." ), 971 i18n("Invalid Response From Server")); 972 return; 973 } 974 } 975 } cd kdepim-3.5.7enterprise20070926 debuild -us -uc cd .. sudo dpkg --install kdepim-3.5.7enterprise20070926.deb make the last line in comment 11: sudo dpkg --install kmail_3.5.7enterprise20070926-0ubuntu2_i386.deb Added for local fix: sudo vi /etc/apt/preferences And add the lines: Package: kmail Pin: origin "" Pin-Priority: 999 This prevents kmail from being overridden by regular updates in debian / ubuntu / kubuntu systems thanks john for the patch; at least, it works (finally) again. is there any chance for that patch to make it into the next kmail release, say 1.9.8? i really like kontact, but thats more than just a slight annoyance... Created attachment 23087 [details] patch for comment 15 The issue here is error handling when receiving a blank uid prortion of a UIDL response.. for instance: 1 1200413730.1[CRLF] 2 [CRLF] 3 1200414111.3[CRLF] . [CRLF] will trigger it. John's debug data from the original bug description shows this nicely. it seems some pop server will generate a bogus uidl response like the above based on the email containing an invalid message-id header. I only tested with Dovecot, and could not reproduce that behavior, but forcing the protocol trace with netcat using the above sequence did create a reproduction. If any of the reporters could identify the pop server that is doing that, we could potentially file a bug against the server which is really the root cause here too. In any event, without a valid UIDL identifier the message cannot be persisted on the server - otherwise, everytime a LIST operation occurred there would be no way to know whether or not there was a local copy of this message and we would keep downloading it over and over again. The attached patch * separates error handling for LIST and UIDL operations (removing the confusing error dialog here that casts doubt on LIST un-necessarily) * takes UIDL lines with an ID but without a valid UID portion and forces a download of those messages and a delete from the server * logs a debug message when it is doing this I can confirm a server that announces itself as IMPLEMENTATION Openwave Email vM.7.08.02.00 201-2186-121-20061213 exhibits this bug.. and the patch from comment 15 works around it. The website seems to indicate this is legacy closed source, so not much chance it will get repaired on the server end. Whether it is a server side error or not, kmail should be able to fetch emails from the worst non standard compliant servers anyways. It cant be that a malformated header forces a mail client to manually delete the message (e.g. via webmail) and restart the client... just my humble opinion... I had not had this error for awhile until couple days ago and again this morning. Went to the server to check each email address and both times it was one or two spam emails. That were left on the servers. Like this morning, Kmail downloaded several emails and then gave me the LIST error. I found the same two spam in two email addresses, no ham present they had been downloaded via Kmail. Deleted both emails in each address and checked server with Kmail again and didn't get any errors. If/when this happens again I could get the email source of each one before deleting to see which one it is. Going to try that next time, will post it if anyone thinks it might help. Christian, re comment 18: I agree it should be worked around in the client. That's what the patch in comment 15 does. In a perfect open source world, it would be fixed in the server too - that's why I noted the server. David, re comment 19: the patch in comment #15 should fix that. SVN commit 766946 by tmcguire: Don't fail when the server sends an invalid UIDL entry. Instead, generate a fake UID for and delete the mail from the server (after downloading it). Based on patch by Patrick McManus <mcmanus at ducksong dot com>. BUG: 127696 M +71 -31 popaccount.cpp M +6 -0 popaccount.h WebSVN link: http://websvn.kde.org/?view=rev&revision=766946 Thanks all for tracking this down and for writing a patch. I've now committed this to trunk, and given that it works OK there, I'll backport it to the 3.5 branch. Please remind me if I haven't done so in two weeks. Sorry for the delay, but the few KMail developers that are there really have a lack of time. I was able to temporarily work around this problem by accessing my POP3 Server using a different email client, moving an offending message from the inbox folder to another folder created just to hold the message. Then Kmail was able to download all of the other messages. The specific message was not a spam message. I will try to report more later. My email is hankivy@hot.rr.com. I can log on to my POP3 Server using telnet, and see all of the operations that are normally hidden. I also have an email that can cause this problem to occur when ever desired. Does any experienced POP3 or mail client developer have any suggestions for me to try to duplicate the problem, and collect diagnosic information? > Does any experienced POP3 or mail client developer have any suggestions for me to try to duplicate the problem, and collect diagnosic information?
There is no need to duplicate the problem, we know what the problem is and already fixed it (in trunk, but I'll backport it soon).
2 weeks have passed, how's the backporting going? >2 weeks have passed, how's the backporting going?
Thanks for reminding my. I thought I had backported a week ago, but apparently the commit failed for some reason.
I've now backported it to the enterprise branch in rev. 775015.
It is to late for 3.5.9 though, which is already tagged. Sorry :(
The diff should apply to the 3.5 branch without problems if you want to manually include it in the release.
Thanks, I'll apply this to the Fedora 3.5.9 packages. Shouldn't this be applied to the regular 3.5 branch too? > Thanks, I'll apply this to the Fedora 3.5.9 packages. Shouldn't this be
> applied to the regular 3.5 branch too?
Yes, it should. I'm hoping someone who has svnmerge+both branches checked out
will do it for me, otherwise I'll do it myself.
Enterprise changes go into 3.5 automatically, roughly once a week. Interesting. I was trying to figure out why this problem seemed intermittent. I have KMail set not to DL messages from the server so if I make a mistake and delete a message I wanted to keep I can retrieve it. I now realize that my behavior of going directly to my mail server and going through my mail deleting unwanted crap it would solve the problem and KMail would work again. I do not have enough knowledge and understanding of how to apply the patch provided here. I have for many years wanted to use linux but could never understand it enough to make it work. With the development of PC-BSD though I am now allmost a full time user of that OS. I love it and all that comes with it. I must admit I still have to run Windows from time to time when needing print and scan because I still can't get those applications working. May I suggest that the patch be developed for PC-BSD as a PBI for us newbies? Thanks Steve |