Bug 119963

Created attachment 14224 [details]
Suggested layout for KStars Julian Date Calculator

For future reference: please submit one wishlist or bug only per report.

SVN commit 500721 by harris:

Fixing bug 119960; partial fix of 119963

11960: All time fields in the astrocalculator now show the 
current UT, not local time

119963: modified the layout of the JD module, moved 
Convert/Clear to the bottom
Increased minimum width of date fields

TODO: 
move Now button (still considering it)
update all 3 fields when Now is pressed
Fix manual input in Date line edit

Thanks for the report.  Will port to trunk as well.

BUG: 119960
CCBUG: 119963



 M  +7 -7      kstarsdata.cpp  
 M  +5 -1      tools/modcalcapcoord.cpp  
 M  +4 -1      tools/modcalcazel.cpp  
 M  +7 -5      tools/modcalcdaylengthdlg.ui  
 M  +6 -1      tools/modcalcjd.cpp  
 M  +133 -120  tools/modcalcjddlg.ui  
 M  +2 -1      tools/modcalcplanets.cpp  
 M  +7 -5      tools/modcalcplanetsdlg.ui  
 M  +4 -1      tools/modcalcvlsr.cpp  

SVN commit 500928 by harris:

Partial fix of bug #119963
It is now possible to manually enter a year in a date edit box

CCBUG: 119963


 M  +15 -0     extdatetimeedit.cpp  


--- branches/KDE/3.5/kdeedu/libkdeedu/extdate/extdatetimeedit.cpp #500927:500928
@@ -1365,6 +1365,17 @@
     d->typing = TRUE;
     QString txt;
     if ( sec == d->yearSection ) {
+      if ( d->overwrite ) {
+	d->y = num;
+	d->overwrite = FALSE;
+	accepted = TRUE;
+      } else {
+	txt = QString::number( 10*d->y + num );
+	if ( txt.length() > 5 ) txt = txt.mid(1);
+	d->y = txt.toInt();
+	accepted = TRUE;
+      }
+/*
 	txt = QString::number( d->y );
 	if ( d->overwrite || txt.length() == 4 ) {
 	    accepted = TRUE;
@@ -1392,6 +1403,7 @@
 		overwrite = TRUE;
 	    }
 	}
+*/
     } else if ( sec == d->monthSection ) {
 	txt = QString::number( d->m );
 	if ( d->overwrite || txt.length() == 2 ) {
@@ -1492,6 +1504,7 @@
   
   int currentYear = ExtDate::currentDate().year();
   int year = d->y;
+/* No longer valid for extended dates
   if ( year < 100 ) {
     int currentCentury = currentYear / 100;
     year += currentCentury * 100;
@@ -1508,6 +1521,7 @@
     year += currentMillennium * 10;
     changed = TRUE;
   }
+*/
   if ( changed && outOfRange( year, d->m, d->d ) ) {
   	if ( minValue().isValid() && date() < minValue() ) {
 	    d->d =  minValue().day();
@@ -1539,6 +1553,7 @@
 {
   if( e->type() == QEvent::FocusOut ) {
     d->typing = FALSE;
+    d->overwrite = TRUE;
     // the following can't be done in fix() because fix() called
     // from all over the place and it will break the old behaviour
     if ( !ExtDate::isValid( d->y, d->m, d->d ) ) {

SVN commit 500929 by harris:

Final fix for bug #119963
Moved the Now button
The Now button now fills in all three fields (JD, MJD and date)

BUG: 119963


 M  +1 -0      modcalcjd.cpp  
 M  +135 -177  modcalcjddlg.ui  

Have downloaded and installed KDE 3.51 -- I observe the fixes. Very nice -- but I expected Compute to be at the left and Now to the right -- that is how I have suggested in the attachment to this bug.

Otherwise the new user searches for the Compute button. (I myself did after installed KDE 3.51.) Since we all read left-to-right, we expect first things at the left, and compute at the left.

So please move the Compute button to the left. Thank you.

should have closed the bug earlier

Sorry for closing prematurely; this is what happens when you (a) add several requests in one bug report, and (b) reopen the bug with a new request.  

In the future, please open a bug for each requested change.  I realize that the change requested which reopens this bug is a direct result of my changes which closed the bug, but it's really much easier for us to keep track of the issues when each bug report is a single, self-contained issue.

Thanks for your continued feedback!

Closing the bug, as the Calculator moduls have been redesigned...they no longer have Compute/Clear buttons.